third_party/WebKit/Source/core/html/shadow/MediaControls.cpp - Issue 2728193003: Show download button even when preload=none

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 2728193003: Show download button even when preload=none (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

index 087b1013c313014963936a4221c8eedf8a6e6212..2b29ad14fbdbab1ff662a37b67dc86737fdae2c2 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

@@ -954,6 +954,8 @@ void MediaControls::networkStateChanged() {

invalidate(m_downloadButton);

invalidate(m_timeline);

invalidate(m_volumeSlider);

+ reset();

mlamouri (slow - plz ping) 2017/03/04 14:10:01 `reset()` is a nuclear weapon. We don't want to re

steimel 2017/03/06 17:44:12 Changed to just directly update the download butto

}

bool MediaControls::overflowMenuVisible() {