Show download button even when preload=none

third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 936 matching lines @@
 }
 
 void MediaControls::networkStateChanged() {
   invalidate(m_playButton);
   invalidate(m_overlayPlayButton);
   invalidate(m_muteButton);
   invalidate(m_fullscreenButton);
   invalidate(m_downloadButton);
   invalidate(m_timeline);
   invalidate(m_volumeSlider);
+
+  reset();

[mlamouri (slow - plz ping), 2017/03/04 14:10:01]

`reset()` is a nuclear weapon. We don't want to reset the entire controls just
to update the download button :)

[steimel, 2017/03/06 17:44:12]

Changed to just directly update the download button's state

 }
 
 bool MediaControls::overflowMenuVisible() {
   return m_overflowList ? m_overflowList->isWanted() : false;
 }
 
 void MediaControls::toggleOverflowMenu() {
   DCHECK(m_overflowList);
 
   if (!m_overflowList->isWanted())
@@ skipping 30 matching lines @@
   visitor->trace(m_overflowList);
   visitor->trace(m_castButton);
   visitor->trace(m_overlayCastButton);
   visitor->trace(m_mediaEventListener);
   visitor->trace(m_windowEventListener);
   visitor->trace(m_orientationLockDelegate);
   HTMLDivElement::trace(visitor);
 }
 
 }  // namespace blink