third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js - Issue 2728133004: Revert of [DevTools] Move 'this' evaluation from ExecutionContext to autocomplete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js

Issue 2728133004: Revert of [DevTools] Move 'this' evaluation from ExecutionContext to autocomplete. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js

diff --git a/third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js b/third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js

index 9fa7447540dd36ef47317da258b5997304afa468..78d6dcc73dcc71ced31bc1b9ffe4920fdf94d50b 100644

--- a/third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js

+++ b/third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js

@@ -70,7 +70,7 @@

var clippedExpression = ObjectUI.JavaScriptAutocomplete._clipExpression(text.substring(0, mapMatch.index));

var fulfill;

var promise = new Promise(x => fulfill = x);

- executionContext.evaluate(clippedExpression || 'this', 'completion', true, true, false, false, false, evaluated);

+ executionContext.evaluate(clippedExpression, 'completion', true, true, false, false, false, evaluated);

return promise;

/**

@@ -190,7 +190,7 @@

if (!expressionString && selectedFrame)

variableNamesInScopes(selectedFrame, receivedPropertyNames);

else

- executionContext.evaluate(expressionString || 'this', 'completion', true, true, false, false, false, evaluated);

+ executionContext.evaluate(expressionString, 'completion', true, true, false, false, false, evaluated);

return promise;

/**

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js » ('j') | no next file with comments »