Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2728113002: [heap] Remove Marking::AnyToGrey and change its callers to use simple marking functions. (Closed)

Created:
3 years, 9 months ago by Hannes Payer (out of office)
Modified:
3 years, 9 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove Marking::AnyToGrey and change its callers to use simple marking functions. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2728113002 Cr-Commit-Position: refs/heads/master@{#43586} Committed: https://chromium.googlesource.com/v8/v8/+/b7944a5cd514010b228c73b3dc1bba00e2f071cd

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -52 lines) Patch
M src/heap/incremental-marking.cc View 1 2 chunks +8 lines, -9 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/heap/marking.h View 1 chunk +0 lines, -5 lines 0 comments Download
M test/unittests/heap/marking-unittest.cc View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
ulan
lgtm https://codereview.chromium.org/2728113002/diff/1/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (right): https://codereview.chromium.org/2728113002/diff/1/src/heap/incremental-marking.cc#newcode125 src/heap/incremental-marking.cc:125: if (obj->IsHeapObject()) { Can we just inline this ...
3 years, 9 months ago (2017-03-03 12:53:13 UTC) #4
Hannes Payer (out of office)
https://codereview.chromium.org/2728113002/diff/1/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (right): https://codereview.chromium.org/2728113002/diff/1/src/heap/incremental-marking.cc#newcode125 src/heap/incremental-marking.cc:125: if (obj->IsHeapObject()) { On 2017/03/03 12:53:13, ulan wrote: > ...
3 years, 9 months ago (2017-03-03 13:07:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728113002/20001
3 years, 9 months ago (2017-03-03 13:07:15 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 13:31:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b7944a5cd514010b228c73b3dc1bba00e2f...

Powered by Google App Engine
This is Rietveld 408576698