Add a fuzzer for png_process_data

Add a fuzzer for png_process_data

The existing png fuzzer uses png_read_rows, which is not used by any
Chromium clients. Use libpng's other API for progressive reading, which
is used both by PNGImageDecoder and PNGCodec.

Reuses much of the code from the existing fuzzer, with a build flag to
choose between them.

No need to supply any callbacks to libpng. This is merely to catch
errors within libpng itself.

BUG=697101
Review-Url: https://codereview.chromium.org/2728103003
Cr-Commit-Position: refs/heads/master@{#454921}
Committed: https://chromium.googlesource.com/chromium/src/+/11a3425fff09d249101f8fb0dcd9c00ddb80283b

[scroggo_chromium, 2017-03-03 21:58:27]

scroggo@chromium.org changed reviewers:
+ mmoroz@chromium.org, noel@chromium.org

[inferno, 2017-03-03 22:02:54]

inferno@chromium.org changed reviewers:
+ inferno@chromium.org

[inferno, 2017-03-03 22:02:55]

lgtm

[Noel Gordon, 2017-03-04 06:01:29]

lgtm

[mmoroz, 2017-03-05 13:47:33]

LGTM, thanks!

[scroggo_chromium, 2017-03-06 18:12:06]

PTAL - latest patch set shares the corpuses amongst the libpng fuzzers

[scroggo_chromium, 2017-03-06 18:12:11]

The CQ bit was checked by scroggo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 18:12:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[inferno, 2017-03-06 18:21:28]

lgtm

[commit-bot: I haz the power, 2017-03-06 19:24:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 19:24:40]

Dry run: This issue passed the CQ dry run.

[scroggo_chromium, 2017-03-06 19:36:04]

The CQ bit was checked by scroggo@chromium.org

[scroggo_chromium, 2017-03-06 19:36:04]

The patchset sent to the CQ was uploaded after l-g-t-m from mmoroz@chromium.org,
noel@chromium.org
Link to the patchset: https://codereview.chromium.org/2728103003/#ps80001
(title: "More sharing")

[commit-bot: I haz the power, 2017-03-06 19:37:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmoroz, 2017-03-06 19:37:30]

LGTM

https://codereview.chromium.org/2728103003/diff/80001/testing/libfuzzer/fuzze...
File testing/libfuzzer/fuzzers/BUILD.gn (right):

https://codereview.chromium.org/2728103003/diff/80001/testing/libfuzzer/fuzze...
testing/libfuzzer/fuzzers/BUILD.gn:166: libpng_seed_corpuses = [
Nice! Maybe even rename it to "png_seed_corpus", but up to you.

[commit-bot: I haz the power, 2017-03-06 19:43:19]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488828964295070,
"parent_rev": "241c4a70278468388b92e7e7439f6412bd945651", "commit_rev":
"11a3425fff09d249101f8fb0dcd9c00ddb80283b"}

[commit-bot: I haz the power, 2017-03-06 19:44:21]

Description was changed from

==========
Add a fuzzer for png_process_data

The existing png fuzzer uses png_read_rows, which is not used by any
Chromium clients. Use libpng's other API for progressive reading, which
is used both by PNGImageDecoder and PNGCodec.

Reuses much of the code from the existing fuzzer, with a build flag to
choose between them.

No need to supply any callbacks to libpng. This is merely to catch
errors within libpng itself.

BUG=697101
==========

to

==========
Add a fuzzer for png_process_data

The existing png fuzzer uses png_read_rows, which is not used by any
Chromium clients. Use libpng's other API for progressive reading, which
is used both by PNGImageDecoder and PNGCodec.

Reuses much of the code from the existing fuzzer, with a build flag to
choose between them.

No need to supply any callbacks to libpng. This is merely to catch
errors within libpng itself.

BUG=697101

Review-Url: https://codereview.chromium.org/2728103003
Cr-Commit-Position: refs/heads/master@{#454921}
Committed:
https://chromium.googlesource.com/chromium/src/+/11a3425fff09d249101f8fb0dcd9...
==========

[commit-bot: I haz the power, 2017-03-06 19:44:24]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/11a3425fff09d249101f8fb0dcd9...