Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2727953005: [MD settings] ignore-extensions to no-extension-indicator (Closed)

Created:
3 years, 9 months ago by dschuyler
Modified:
3 years, 9 months ago
Reviewers:
scottchen, Dan Beam
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, Dan Beam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] ignore-extensions to no-extension-indicator This CL changes the logic on the ignore-extensions property and renames that property to no-extension-indicator. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2727953005 Cr-Commit-Position: refs/heads/master@{#454947} Committed: https://chromium.googlesource.com/chromium/src/+/df6c3b36d0a8949c663d619ec98eef744499b1e8

Patch Set 1 : set upstream #

Patch Set 2 : update #

Total comments: 2

Patch Set 3 : wrapped lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/on_startup_page/on_startup_page.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/system_page/system_page.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/policy/cr_policy_pref_behavior.js View 3 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 27 (21 generated)
dschuyler
3 years, 9 months ago (2017-03-03 20:20:04 UTC) #9
Dan Beam
lgtm https://codereview.chromium.org/2727953005/diff/40001/chrome/browser/resources/settings/appearance_page/appearance_page.html File chrome/browser/resources/settings/appearance_page/appearance_page.html (right): https://codereview.chromium.org/2727953005/diff/40001/chrome/browser/resources/settings/appearance_page/appearance_page.html#newcode114 chrome/browser/resources/settings/appearance_page/appearance_page.html:114: pref="[[prefs.homepage_is_newtabpage]]" no-extension-indicator> 80 cols
3 years, 9 months ago (2017-03-03 21:59:17 UTC) #15
dschuyler
https://codereview.chromium.org/2727953005/diff/40001/chrome/browser/resources/settings/appearance_page/appearance_page.html File chrome/browser/resources/settings/appearance_page/appearance_page.html (right): https://codereview.chromium.org/2727953005/diff/40001/chrome/browser/resources/settings/appearance_page/appearance_page.html#newcode114 chrome/browser/resources/settings/appearance_page/appearance_page.html:114: pref="[[prefs.homepage_is_newtabpage]]" no-extension-indicator> On 2017/03/03 21:59:17, Dan Beam wrote: > ...
3 years, 9 months ago (2017-03-03 22:27:26 UTC) #18
scottchen
On 2017/03/03 22:27:26, dschuyler wrote: > https://codereview.chromium.org/2727953005/diff/40001/chrome/browser/resources/settings/appearance_page/appearance_page.html > File chrome/browser/resources/settings/appearance_page/appearance_page.html > (right): > > https://codereview.chromium.org/2727953005/diff/40001/chrome/browser/resources/settings/appearance_page/appearance_page.html#newcode114 ...
3 years, 9 months ago (2017-03-03 23:49:33 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727953005/60001
3 years, 9 months ago (2017-03-06 19:31:36 UTC) #24
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 20:41:29 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/df6c3b36d0a8949c663d619ec98e...

Powered by Google App Engine
This is Rietveld 408576698