Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2727953002: Added histogram for resize listener duration. (Closed)

Created:
3 years, 9 months ago by bokan
Modified:
3 years, 9 months ago
Reviewers:
dtapuska, Steven Holte
CC:
chromium-reviews, blink-reviews, blink-reviews-frames_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added histogram for resize listener duration. Tracks how long it takes to execute event listeners on the main frame. Note that this will track how long *all* listeners took to execute per-event. Added since this will be useful for decisions around various viewport actions and whether we need to add a new resize event for resizes from the URL bar and keyboard which resize only the visual viewport. BUG=697931 Review-Url: https://codereview.chromium.org/2727953002 Cr-Commit-Position: refs/heads/master@{#454383} Committed: https://chromium.googlesource.com/chromium/src/+/0a52f5a31e5b6a2b3faba076efc944d55d6c4a58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bokan
3 years, 9 months ago (2017-03-02 17:31:48 UTC) #3
dtapuska
On 2017/03/02 17:31:48, bokan wrote: lgtm
3 years, 9 months ago (2017-03-02 17:38:31 UTC) #4
Steven Holte
lgtm
3 years, 9 months ago (2017-03-02 19:53:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727953002/1
3 years, 9 months ago (2017-03-02 19:55:09 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 21:37:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0a52f5a31e5b6a2b3faba076efc9...

Powered by Google App Engine
This is Rietveld 408576698