Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2727903004: Update boilerplate.py to add ARC header guards to iOS ObjCpp files. (Closed)

Created:
3 years, 9 months ago by sdefresne
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke, stkhapugin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update boilerplate.py to add ARC header guards to iOS ObjCpp files. Chrome on iOS is migrating to use ARC (Automatic Reference Counting) for all Objective-C files so update boilerplate.py script to add the ARC header guard to all newly create iOS Objective-C++ files. BUG=None Review-Url: https://codereview.chromium.org/2727903004 Cr-Commit-Position: refs/heads/master@{#455013} Committed: https://chromium.googlesource.com/chromium/src/+/d6844b4a3ae4a7728690dd1801896fdbb199f64c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M tools/boilerplate.py View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
sdefresne
Can you both please take a look? dpranke: need OWNERS review stkhapugin: as lead of ...
3 years, 9 months ago (2017-03-04 01:39:15 UTC) #4
stkhapugin
lgtm
3 years, 9 months ago (2017-03-06 10:20:53 UTC) #7
sdefresne
dpranke: ping
3 years, 9 months ago (2017-03-06 22:35:42 UTC) #8
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-07 00:27:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727903004/1
3 years, 9 months ago (2017-03-07 00:57:25 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 01:12:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d6844b4a3ae4a7728690dd180189...

Powered by Google App Engine
This is Rietveld 408576698