Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2727863003: [compiler] Make ahaas@ and clemensh@ owners for wasm-* (Closed)

Created:
3 years, 9 months ago by Clemens Hammacher
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, ahaas
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Make ahaas@ and clemensh@ owners for wasm-* R=titzer@chromium.org, mstarzinger@chromium.org CC=ahaas@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2727863003 Cr-Commit-Position: refs/heads/master@{#43532} Committed: https://chromium.googlesource.com/v8/v8/+/4cbac8ffb2ea89b5e44fc7e9fd3f4baecdea023d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/compiler/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Clemens Hammacher
3 years, 9 months ago (2017-03-02 09:08:38 UTC) #1
titzer
lgtm (if that actually works)
3 years, 9 months ago (2017-03-02 09:10:03 UTC) #6
Michael Starzinger
LGTM. Benedikt, please also sign off on this.
3 years, 9 months ago (2017-03-02 09:12:27 UTC) #8
Benedikt Meurer
LGTM
3 years, 9 months ago (2017-03-02 09:21:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727863003/1
3 years, 9 months ago (2017-03-02 09:23:25 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 09:24:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4cbac8ffb2ea89b5e44fc7e9fd3f4baecde...

Powered by Google App Engine
This is Rietveld 408576698