Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: third_party/WebKit/Source/core/style/StyleDifference.h

Issue 2727843004: needsPaintInvalidation() should not return true for selection. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/selection/selection-and-text-repaint-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/StyleDifference.h
diff --git a/third_party/WebKit/Source/core/style/StyleDifference.h b/third_party/WebKit/Source/core/style/StyleDifference.h
index a646e54bb1e584102df98292b2971d1198e628bc..b9fba7a1ab10ce8ab4643bf5d95210b28ff14d84 100644
--- a/third_party/WebKit/Source/core/style/StyleDifference.h
+++ b/third_party/WebKit/Source/core/style/StyleDifference.h
@@ -52,7 +52,7 @@ class StyleDifference {
}
bool needsPaintInvalidation() const {
mstensho (USE GERRIT) 2017/03/02 19:35:26 Shouldn't this be renamed to needsFullPaintInvalid
rune 2017/03/03 09:13:09 Done.
- return m_paintInvalidationType != NoPaintInvalidation;
+ return m_paintInvalidationType > PaintInvalidationSelection;
mstensho (USE GERRIT) 2017/03/02 19:35:26 ... and to make it more obvious that selection inv
rune 2017/03/03 09:13:09 Done.
}
// The text selection needs paint invalidation.
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/selection/selection-and-text-repaint-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698