[sensors][win] Add support for AbsoluteOrientation sensor

[sensors][win] Add support for AbsoluteOrientation sensor

This CL adds support for AbsoluteOrientation sensor for
Windows platform. GenericSensor unit tests are updated
to verify new functionality.

W3C ED: https://w3c.github.io/orientation-sensor/

BUG=661478
Review-Url: https://codereview.chromium.org/2727813004
Cr-Commit-Position: refs/heads/master@{#459085}
Committed: https://chromium.googlesource.com/chromium/src/+/ededdbfe3f3f4863d0d5ed6fc92d7f22445bf681

[shalamov, 2017-03-16 12:59:33]

Description was changed from

==========
[sensors][win] Add support for DeviceOrientation sensor

This CL adds support for DeviceOrientation sensor for
Windows platform. GenericSensor unit tests are updated
to verify new functionality.

BUG=669765
==========

to

==========
[sensors][win] Add support for AbsoluteOrientation sensor

This CL adds support for AbsoluteOrientation sensor for
Windows platform. GenericSensor unit tests are updated
to verify new functionality.

W3C ED: https://w3c.github.io/orientation-sensor/

BUG=669765
==========

[shalamov, 2017-03-21 11:33:08]

Description was changed from

==========
[sensors][win] Add support for AbsoluteOrientation sensor

This CL adds support for AbsoluteOrientation sensor for
Windows platform. GenericSensor unit tests are updated
to verify new functionality.

W3C ED: https://w3c.github.io/orientation-sensor/

BUG=669765
==========

to

==========
[sensors][win] Add support for AbsoluteOrientation sensor

This CL adds support for AbsoluteOrientation sensor for
Windows platform. GenericSensor unit tests are updated
to verify new functionality.

W3C ED: https://w3c.github.io/orientation-sensor/

BUG=661478
==========

[shalamov, 2017-03-21 11:34:26]

alexander.shalamov@intel.com changed reviewers:
+ mikhail.pozdnyakov@intel.com, reillyg@chromium.org

[shalamov, 2017-03-21 11:34:27]

PTAL, this CL depends on https://codereview.chromium.org/2726093003/ , I will
run dry run when added enumeration is landed.

[Mikhail, 2017-03-21 12:04:59]

lgtm

[Reilly Grant (use Gerrit), 2017-03-21 18:25:06]

https://codereview.chromium.org/2727813004/diff/20001/device/generic_sensor/p...
File device/generic_sensor/platform_sensor_and_provider_unittest_win.cc (right):

https://codereview.chromium.org/2727813004/diff/20001/device/generic_sensor/p...
device/generic_sensor/platform_sensor_and_provider_unittest_win.cc:595:
PropVariantClear(&pvZ);
Please use base::win::ScopedPropVariant to ensure that these are cleared on all
exit paths.

https://codereview.chromium.org/2727813004/diff/20001/device/generic_sensor/p...
device/generic_sensor/platform_sensor_and_provider_unittest_win.cc:714:
InitPropVariantFromGUIDAsBuffer(SENSOR_DATA_TYPE_QUATERNION.fmtid, &pvQuat);
Can you add a comment explaining that the Windows API is weird and "FromGUID" is
the correct initializer here because it generates the expected VT_ARRAY | VT_UI1
variant type?

https://codereview.chromium.org/2727813004/diff/20001/device/generic_sensor/p...
File device/generic_sensor/platform_sensor_reader_win.cc (right):

https://codereview.chromium.org/2727813004/diff/20001/device/generic_sensor/p...
device/generic_sensor/platform_sensor_reader_win.cc:173: PROPVARIANT
quat_variant = {};
This should also be a base::win::ScopedPropVariant to avoid leaking the memory
pointed to by quat_variant.caub.pElems.

[shalamov, 2017-03-23 13:34:27]

The CQ bit was checked by alexander.shalamov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 13:34:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shalamov, 2017-03-23 13:35:30]

https://codereview.chromium.org/2727813004/diff/20001/device/generic_sensor/p...
File device/generic_sensor/platform_sensor_and_provider_unittest_win.cc (right):

https://codereview.chromium.org/2727813004/diff/20001/device/generic_sensor/p...
device/generic_sensor/platform_sensor_and_provider_unittest_win.cc:595:
PropVariantClear(&pvZ);
On 2017/03/21 18:25:06, Reilly Grant wrote:
> Please use base::win::ScopedPropVariant to ensure that these are cleared on
all
> exit paths.

Done.

https://codereview.chromium.org/2727813004/diff/20001/device/generic_sensor/p...
device/generic_sensor/platform_sensor_and_provider_unittest_win.cc:714:
InitPropVariantFromGUIDAsBuffer(SENSOR_DATA_TYPE_QUATERNION.fmtid, &pvQuat);
On 2017/03/21 18:25:06, Reilly Grant wrote:
> Can you add a comment explaining that the Windows API is weird and "FromGUID"
is
> the correct initializer here because it generates the expected VT_ARRAY |
VT_UI1
> variant type?

Done.

https://codereview.chromium.org/2727813004/diff/20001/device/generic_sensor/p...
File device/generic_sensor/platform_sensor_reader_win.cc (right):

https://codereview.chromium.org/2727813004/diff/20001/device/generic_sensor/p...
device/generic_sensor/platform_sensor_reader_win.cc:173: PROPVARIANT
quat_variant = {};
On 2017/03/21 18:25:06, Reilly Grant wrote:
> This should also be a base::win::ScopedPropVariant to avoid leaking the memory
> pointed to by quat_variant.caub.pElems.

Done.

[commit-bot: I haz the power, 2017-03-23 14:40:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 14:40:12]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2017-03-23 14:48:55]

lgtm

[shalamov, 2017-03-23 15:03:58]

The CQ bit was checked by alexander.shalamov@intel.com

[shalamov, 2017-03-23 15:03:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikhail.pozdnyakov@intel.com
Link to the patchset: https://codereview.chromium.org/2727813004/#ps40001
(title: "Fixes for comments from Reilly")

[commit-bot: I haz the power, 2017-03-23 15:04:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 15:08:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490281438177700,
"parent_rev": "aa55dfc18b71397a274dbb9f123854cccd2a9651", "commit_rev":
"cd34ca2ee8332ce52fa62ccfb7e142fe51ca2f0f"}

[commit-bot: I haz the power, 2017-03-23 15:13:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490281438177700,
"parent_rev": "0c49b9e013ab38e1c6e4bfafa875548b94e54dff", "commit_rev":
"ededdbfe3f3f4863d0d5ed6fc92d7f22445bf681"}

[commit-bot: I haz the power, 2017-03-23 15:14:17]

Description was changed from

==========
[sensors][win] Add support for AbsoluteOrientation sensor

This CL adds support for AbsoluteOrientation sensor for
Windows platform. GenericSensor unit tests are updated
to verify new functionality.

W3C ED: https://w3c.github.io/orientation-sensor/

BUG=661478
==========

to

==========
[sensors][win] Add support for AbsoluteOrientation sensor

This CL adds support for AbsoluteOrientation sensor for
Windows platform. GenericSensor unit tests are updated
to verify new functionality.

W3C ED: https://w3c.github.io/orientation-sensor/

BUG=661478

Review-Url: https://codereview.chromium.org/2727813004
Cr-Commit-Position: refs/heads/master@{#459085}
Committed:
https://chromium.googlesource.com/chromium/src/+/ededdbfe3f3f4863d0d5ed6fc92d...
==========

[commit-bot: I haz the power, 2017-03-23 15:14:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ededdbfe3f3f4863d0d5ed6fc92d...