Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: runtime/vm/debugger.cc

Issue 2727803002: Fix setting breakpoint setting in await statements (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/debugger.cc
diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc
index 5cf5419f449621b75e7f9f63387cb4fe403fa3e9..ed31dd7aed5871049c614b8423b14bd1aee3294d 100644
--- a/runtime/vm/debugger.cc
+++ b/runtime/vm/debugger.cc
@@ -620,8 +620,8 @@ intptr_t ActivationFrame::TryIndex() {
intptr_t ActivationFrame::LineNumber() {
// Compute line number lazily since it causes scanning of the script.
- if ((line_number_ < 0) && TokenPos().IsReal()) {
- const TokenPosition token_pos = TokenPos();
+ if ((line_number_ < 0) && TokenPos().IsSourcePosition()) {
+ const TokenPosition token_pos = TokenPos().SourcePosition();
const Script& script = Script::Handle(SourceScript());
script.GetTokenLocation(token_pos, &line_number_, NULL);
}
@@ -631,8 +631,8 @@ intptr_t ActivationFrame::LineNumber() {
intptr_t ActivationFrame::ColumnNumber() {
// Compute column number lazily since it causes scanning of the script.
- if ((column_number_ < 0) && TokenPos().IsReal()) {
- const TokenPosition token_pos = TokenPos();
+ if ((column_number_ < 0) && TokenPos().IsSourcePosition()) {
+ const TokenPosition token_pos = TokenPos().SourcePosition();
const Script& script = Script::Handle(SourceScript());
if (script.HasSource()) {
script.GetTokenLocation(token_pos, &line_number_, &column_number_);
@@ -1359,10 +1359,7 @@ void ActivationFrame::PrintToJSONObjectRegular(JSONObject* jsobj, bool full) {
const Script& script = Script::Handle(SourceScript());
jsobj->AddProperty("type", "Frame");
jsobj->AddProperty("kind", KindToCString(kind_));
- TokenPosition pos = TokenPos();
- if (pos.IsSynthetic()) {
- pos = pos.FromSynthetic();
- }
+ const TokenPosition pos = TokenPos().SourcePosition();
jsobj->AddLocation(script, pos);
jsobj->AddProperty("function", function(), !full);
jsobj->AddProperty("code", code());
@@ -1409,10 +1406,7 @@ void ActivationFrame::PrintToJSONObjectAsyncCausal(JSONObject* jsobj,
jsobj->AddProperty("type", "Frame");
jsobj->AddProperty("kind", KindToCString(kind_));
const Script& script = Script::Handle(SourceScript());
- TokenPosition pos = TokenPos();
- if (pos.IsSynthetic()) {
- pos = pos.FromSynthetic();
- }
+ const TokenPosition pos = TokenPos().SourcePosition();
jsobj->AddLocation(script, pos);
jsobj->AddProperty("function", function(), !full);
jsobj->AddProperty("code", code());
@@ -3615,10 +3609,12 @@ RawError* Debugger::PauseBreakpoint() {
}
if (FLAG_verbose_debug) {
- OS::Print(">>> hit breakpoint at %s:%" Pd " (token %s) (address %#" Px
- ")\n",
- String::Handle(cbpt->SourceUrl()).ToCString(), cbpt->LineNumber(),
- cbpt->token_pos().ToCString(), top_frame->pc());
+ OS::Print(">>> hit breakpoint %" Pd " at %s:%" Pd
+ " (token %s) "
+ "(address %#" Px ")\n",
+ bpt_hit->id(), String::Handle(cbpt->SourceUrl()).ToCString(),
+ cbpt->LineNumber(), cbpt->token_pos().ToCString(),
+ top_frame->pc());
}
CacheStackTraces(stack_trace, CollectAsyncCausalStackTrace());

Powered by Google App Engine
This is Rietveld 408576698