Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2449)

Unified Diff: runtime/vm/token_position.h

Issue 2727803002: Fix setting breakpoint setting in await statements (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/source_report.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/token_position.h
diff --git a/runtime/vm/token_position.h b/runtime/vm/token_position.h
index b0a2062083f2b757debd3cd541b1e4c9c120ce8b..65dd3ed353eff1f555b41fef6bf97c2135c79f55 100644
--- a/runtime/vm/token_position.h
+++ b/runtime/vm/token_position.h
@@ -134,9 +134,11 @@ class TokenPosition {
bool IsReal() const { return value_ >= kMinSourcePos; }
// Is |this| a source position?
- bool IsSourcePosition() const {
- return IsReal() || IsNoSource() || IsSynthetic();
- }
+ bool IsSourcePosition() const { return IsReal() || IsSynthetic(); }
Florian Schneider 2017/03/02 02:44:13 This seems better. Was this another bug that NoSou
hausner 2017/03/02 06:14:00 This function was only used in one place. It wasn'
+
+ // Convert |this| into a real source position. Sentinel values remain
+ // unchanged.
+ TokenPosition SourcePosition() const { return FromSynthetic(); }
// Is |this| a debug pause source position?
bool IsDebugPause() const {
« no previous file with comments | « runtime/vm/source_report.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698