Add an Error class for ServiceWorkers

Source/modules/serviceworkers/ServiceWorkerError.cpp

Index: Source/modules/serviceworkers/ServiceWorkerError.cpp
diff --git a/Source/core/rendering/RenderingNodeProxy.cpp b/Source/modules/serviceworkers/ServiceWorkerError.cpp
similarity index 78%
copy from Source/core/rendering/RenderingNodeProxy.cpp
copy to Source/modules/serviceworkers/ServiceWorkerError.cpp
index 303972ba1e224ed6bdda2c67043fa07b1bc22c1e..6e20535ef48bd3fdb12c4919c7c0a3e3a77ba7c8 100644
--- a/Source/core/rendering/RenderingNodeProxy.cpp
+++ b/Source/modules/serviceworkers/ServiceWorkerError.cpp
@@ -29,24 +29,20 @@
  */
 
 #include "config.h"
-#include "core/rendering/RenderingNodeProxy.h"
-
-#include "core/dom/Node.h"
+#include "ServiceWorkerError.h"
 
+using WebKit::WebServiceWorkerError;
 namespace WebCore {
 
-RenderingNodeProxy::RenderingNodeProxy(Node* node)
-    : m_node(node)
-{
-}
-
-RenderingNodeProxy::~RenderingNodeProxy()
-{
-}
-
-bool RenderingNodeProxy::hasTagName(const QualifiedName& tagName) const
+const String& ServiceWorkerError::GetErrorString(WebKit::WebServiceWorkerError::ErrorType type)
 {
-    return m_node->hasTagName(tagName);
+    DEFINE_STATIC_LOCAL(AtomicString, registrationError, ("RegistrationError", AtomicString::ConstructFromLiteral));

[kinuko, 2013/10/15 23:44:44]

This is not thread safe, I think we could simply use const char* string
constants + switch/case (or const char* string array + array access by enum
code).

[michaeln, 2013/10/16 01:19:16]

this function looks iffy from a threading point of view, the references to the
objects returned have thread affinity :(

maybe...

String GetErrorName(...) {
  switch(e) {
  case FooError:
      return String("foo error name");
  }
}

+    switch (type) {
+    case WebServiceWorkerError::RegistrationError:
+        return registrationError;
+    default:
+        ASSERT_NOT_REACHED();
+    }
 }
 
 }