Add an Error class for ServiceWorkers

Source/modules/serviceworkers/ServiceWorkerError.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 11 matching lines @@
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
-#include "core/rendering/RenderingNodeProxy.h"
+#include "ServiceWorkerError.h"
 
-#include "core/dom/Node.h"
-
+using WebKit::WebServiceWorkerError;
 namespace WebCore {
 
-RenderingNodeProxy::RenderingNodeProxy(Node* node)
-    : m_node(node)
+const String& ServiceWorkerError::GetErrorString(WebKit::WebServiceWorkerError::ErrorType type)
 {
-}
-
-RenderingNodeProxy::~RenderingNodeProxy()
-{
-}
-
-bool RenderingNodeProxy::hasTagName(const QualifiedName& tagName) const
-{
-    return m_node->hasTagName(tagName);
+    DEFINE_STATIC_LOCAL(AtomicString, registrationError, ("RegistrationError", AtomicString::ConstructFromLiteral));

[kinuko, 2013/10/15 23:44:44]

This is not thread safe, I think we could simply use const char* string
constants + switch/case (or const char* string array + array access by enum
code).

[michaeln, 2013/10/16 01:19:16]

this function looks iffy from a threading point of view, the references to the
objects returned have thread affinity :(

maybe...

String GetErrorName(...) {
  switch(e) {
  case FooError:
      return String("foo error name");
  }
}

+    switch (type) {
+    case WebServiceWorkerError::RegistrationError:
+        return registrationError;
+    default:
+        ASSERT_NOT_REACHED();
+    }
 }
 
 }