Merging to M57 branch 2987.

Merging to M57 branch 2987.

Add a deprecation message to rtcpMuxPolicy of negotiate.

When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set
to be "negotiate", the deprecation message will be return to the console.

If this is approved, the change will be merged to M57.

BUG=chromium:685727
Review-Url: https://codereview.chromium.org/2720763004
Cr-Commit-Position: refs/heads/master@{#453771}
(cherry picked from commit 918bb2c91f07a2cce51cea68554bd56566dec0dc)

[Zhi Huang, 2017-03-02 02:02:36]

The CQ bit was checked by zhihuang@webrtc.org

[commit-bot: I haz the power, 2017-03-02 02:04:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 02:04:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 02:04:21]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[zhihuang1, 2017-03-02 02:08:26]

zhihuang@chromium.org changed reviewers:
+ foolip@chromium.org
- zhihuang@webrtc.org

[zhihuang1, 2017-03-02 02:08:27]

Hi Philip,

This is a CL that merge the deprecation message to M57. 
It needs to be LGTMed before submitting.
Please take a look. Thanks.

[foolip, 2017-03-03 14:54:55]

The CQ bit was checked by foolip@chromium.org

[foolip, 2017-03-03 14:54:56]

lgtm

[commit-bot: I haz the power, 2017-03-03 14:55:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 14:55:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 14:55:12]

CLs for remote refs other than refs/heads/master must contain NOTRY=true and
NOPRESUBMIT=true in order for the CQ to process them

[foolip, 2017-03-03 15:23:40]

On 2017/03/03 14:55:12, commit-bot: I haz the power wrote:
> CLs for remote refs other than refs/heads/master must contain NOTRY=true and
> NOPRESUBMIT=true in order for the CQ to process them

Oh, this made me realize this CL doesn't look like a merge usually does.
https://www.chromium.org/developers/how-tos/drover has the documentation, and
I'm now using that to merge this CL and the one before it that it depends on (to
compile at all).

[foolip, 2017-03-03 15:28:57]

Description was changed from

==========
Merging to M57 branch 2987.

Add a deprecation message to rtcpMuxPolicy of negotiate.

When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set
to be "negotiate", the deprecation message will be return to the console.

If this is approved, the change will be merged to M57.

BUG=chromium:685727

Review-Url: https://codereview.chromium.org/2720763004
Cr-Commit-Position: refs/heads/master@{#453771}
(cherry picked from commit 918bb2c91f07a2cce51cea68554bd56566dec0dc)
==========

to

==========
Merging to M57 branch 2987.

Add a deprecation message to rtcpMuxPolicy of negotiate.

When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set
to be "negotiate", the deprecation message will be return to the console.

If this is approved, the change will be merged to M57.

BUG=chromium:685727

Review-Url: https://codereview.chromium.org/2720763004
Cr-Commit-Position: refs/heads/master@{#453771}
(cherry picked from commit 918bb2c91f07a2cce51cea68554bd56566dec0dc)
==========

[zhihuang1, 2017-03-03 18:12:47]

On 2017/03/03 15:23:40, foolip wrote:
> On 2017/03/03 14:55:12, commit-bot: I haz the power wrote:
> > CLs for remote refs other than refs/heads/master must contain NOTRY=true and
> > NOPRESUBMIT=true in order for the CQ to process them
> 
> Oh, this made me realize this CL doesn't look like a merge usually does.
> https://www.chromium.org/developers/how-tos/drover has the documentation, and
> I'm now using that to merge this CL and the one before it that it depends on
(to
> compile at all).

Thanks for doing this!

For my own education, I used the command "git drover --branch 2987 --cherry-pick
918bb2c91f07a2cce51cea68554bd56566dec0dc" but I can't landed it since I'm not a
full committer. This CL seems to be created automatically by that command. What
did I miss here?

[foolip, 2017-03-07 06:05:18]

On 2017/03/03 18:12:47, zhihuang1 wrote:
> On 2017/03/03 15:23:40, foolip wrote:
> > On 2017/03/03 14:55:12, commit-bot: I haz the power wrote:
> > > CLs for remote refs other than refs/heads/master must contain NOTRY=true
and
> > > NOPRESUBMIT=true in order for the CQ to process them
> > 
> > Oh, this made me realize this CL doesn't look like a merge usually does.
> > https://www.chromium.org/developers/how-tos/drover has the documentation,
and
> > I'm now using that to merge this CL and the one before it that it depends on
> (to
> > compile at all).
> 
> Thanks for doing this!
> 
> For my own education, I used the command "git drover --branch 2987
--cherry-pick
> 918bb2c91f07a2cce51cea68554bd56566dec0dc" but I can't landed it since I'm not
a
> full committer. This CL seems to be created automatically by that command.
What
> did I miss here?

Did that at least upload a CL? It could be that you just need an LGTM on that
issue to land it. If it failed to even create a CL, that would be a problem...