cros: Convert SessionStateDelegateChromeOS tests

cros: Convert SessionStateDelegateChromeOS tests

SessionStateDelegate(ChromeOS) is deprecated. Convert existing test
cases for SessionControllerClient.

BUG=648964
Review-Url: https://codereview.chromium.org/2727763002
Cr-Commit-Position: refs/heads/master@{#454612}
Committed: https://chromium.googlesource.com/chromium/src/+/3a1bc5275b499bc6b4545bba2aa80b2980b6e094

[xiyuan, 2017-03-01 21:53:09]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[xiyuan, 2017-03-01 21:53:36]

xiyuan@chromium.org changed reviewers:
+ jamescook@chromium.org

[commit-bot: I haz the power, 2017-03-01 21:53:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-03-01 22:02:08]

LGTM with optional suggestion

https://codereview.chromium.org/2727763002/diff/1/chrome/browser/ui/ash/sessi...
File chrome/browser/ui/ash/session_controller_client_unittest.cc (right):

https://codereview.chromium.org/2727763002/diff/1/chrome/browser/ui/ash/sessi...
chrome/browser/ui/ash/session_controller_client_unittest.cc:133:
SessionControllerClient::DoCycleActiveUser(true);
optional: It would be nice if this function took an enum NEXT/PREVIOUS or an
index +1/-1 instead of true/false.

[xiyuan, 2017-03-01 22:41:03]

https://codereview.chromium.org/2727763002/diff/1/chrome/browser/ui/ash/sessi...
File chrome/browser/ui/ash/session_controller_client_unittest.cc (right):

https://codereview.chromium.org/2727763002/diff/1/chrome/browser/ui/ash/sessi...
chrome/browser/ui/ash/session_controller_client_unittest.cc:133:
SessionControllerClient::DoCycleActiveUser(true);
On 2017/03/01 22:02:08, James Cook wrote:
> optional: It would be nice if this function took an enum NEXT/PREVIOUS or an
> index +1/-1 instead of true/false.

Sounds good. It would make more sense to also update the mojo interface to use
an enum as well. Let me do it in another CL and rebase this one after the enum
one lands.

[James Cook, 2017-03-01 22:42:57]

sgtm

[commit-bot: I haz the power, 2017-03-01 23:07:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 23:07:34]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-03-02 23:17:22]

https://codereview.chromium.org/2727763002/diff/1/chrome/browser/ui/ash/sessi...
File chrome/browser/ui/ash/session_controller_client_unittest.cc (right):

https://codereview.chromium.org/2727763002/diff/1/chrome/browser/ui/ash/sessi...
chrome/browser/ui/ash/session_controller_client_unittest.cc:133:
SessionControllerClient::DoCycleActiveUser(true);
On 2017/03/01 22:02:08, James Cook wrote:
> optional: It would be nice if this function took an enum NEXT/PREVIOUS or an
> index +1/-1 instead of true/false.

Done.

[xiyuan, 2017-03-02 23:17:32]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2017-03-02 23:17:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2727763002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-02 23:18:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 01:23:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 01:23:28]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2017-03-03 16:53:28]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2017-03-03 16:53:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 17:44:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488560008279400,
"parent_rev": "59b1a9c899d5f75c24d848df7f0975e217f8bfc3", "commit_rev":
"3a1bc5275b499bc6b4545bba2aa80b2980b6e094"}

[commit-bot: I haz the power, 2017-03-03 17:44:43]

Description was changed from

==========
cros: Convert SessionStateDelegateChromeOS tests

SessionStateDelegate(ChromeOS) is deprecated. Convert existing test
cases for SessionControllerClient.

BUG=648964
==========

to

==========
cros: Convert SessionStateDelegateChromeOS tests

SessionStateDelegate(ChromeOS) is deprecated. Convert existing test
cases for SessionControllerClient.

BUG=648964

Review-Url: https://codereview.chromium.org/2727763002
Cr-Commit-Position: refs/heads/master@{#454612}
Committed:
https://chromium.googlesource.com/chromium/src/+/3a1bc5275b499bc6b4545bba2aa8...
==========

[commit-bot: I haz the power, 2017-03-03 17:44:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3a1bc5275b499bc6b4545bba2aa8...