Update FWMP in TPM

chromeos/dbus/cryptohome_client.h

Index: chromeos/dbus/cryptohome_client.h
diff --git a/chromeos/dbus/cryptohome_client.h b/chromeos/dbus/cryptohome_client.h
index 8fc61f94b0e4f64241a565479d13f9aad0ed5e41..e613a63997de714706125c96d63a4b54371c5a65 100644
--- a/chromeos/dbus/cryptohome_client.h
+++ b/chromeos/dbus/cryptohome_client.h
@@ -35,6 +35,12 @@ class Identification;
 
 } // namespace cryptohome
 
+namespace google {
+namespace protobuf {
+class MessageLite;
+}

[Daniel Erat, 2017/03/06 21:18:26]

nit: add // namespace protobuf

[igorcov, 2017/03/09 12:22:57]

Done.

+}  // namespace google
+
 namespace chromeos {
 
 // CryptohomeClient is used to communicate with the Cryptohome service.
@@ -555,6 +561,11 @@ class CHROMEOS_EXPORT CryptohomeClient : public DBusClient {
       const cryptohome::FlushAndSignBootAttributesRequest& request,
       const ProtobufMethodCallback& callback) = 0;
 
+  virtual void AsyncTpmUpdateFirmwareManagementParameters(

[Daniel Erat, 2017/03/06 21:18:26]

add a comment documenting what this does. can you also drop "Async" from the
name? some of the async methods in this class have that prefix while others
don't. i think that the callback param makes it pretty clear that this is async,
so a shorter name is probably better.

[igorcov, 2017/03/09 12:22:57]

Done.

+      const std::string& method_name,

[Daniel Erat, 2017/03/06 21:18:26]

i think that this leaks too many of the IPC implementation details to the
caller. please add separate methods for updating and removing that take the
concrete protobuf type instead of this generic version.

[igorcov, 2017/03/09 12:22:57]

Done.

+      const google::protobuf::MessageLite& request,
+      const ProtobufMethodCallback& callback) = 0;
+
  protected:
   // Create() should be used instead.
   CryptohomeClient();