Update FWMP in TPM

chromeos/dbus/cryptohome_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_CRYPTOHOME_CLIENT_H_
 #define CHROMEOS_DBUS_CRYPTOHOME_CLIENT_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 17 matching lines @@
 class GetKeyDataRequest;
 class MountRequest;
 class RemoveKeyRequest;
 class SetBootAttributeRequest;
 class UpdateKeyRequest;
 
 class Identification;
 
 } // namespace cryptohome
 
+namespace google {
+namespace protobuf {
+class MessageLite;
+}

[Daniel Erat, 2017/03/06 21:18:26]

nit: add // namespace protobuf

[igorcov, 2017/03/09 12:22:57]

Done.

+}  // namespace google
+
 namespace chromeos {
 
 // CryptohomeClient is used to communicate with the Cryptohome service.
 // All method should be called from the origin thread (UI thread) which
 // initializes the DBusThreadManager instance.
 class CHROMEOS_EXPORT CryptohomeClient : public DBusClient {
  public:
   // Constant that will be passed to AsyncMethodCallback to indicate that
   // cryptohome is not ready yet.
   static const int kNotReadyAsyncId;
@@ skipping 500 matching lines @@
 
   // Asynchronously calls FlushAndSignBootAttributes method. |callback| is
   // called after method call, and with reply protobuf.
   // FlushAndSignBootAttributes makes all pending boot attribute settings
   // available, and have them signed by a special TPM key. This method always
   // fails after any user, publuc, or guest session starts.
   virtual void FlushAndSignBootAttributes(
       const cryptohome::FlushAndSignBootAttributesRequest& request,
       const ProtobufMethodCallback& callback) = 0;
 
+  virtual void AsyncTpmUpdateFirmwareManagementParameters(

[Daniel Erat, 2017/03/06 21:18:26]

add a comment documenting what this does. can you also drop "Async" from the
name? some of the async methods in this class have that prefix while others
don't. i think that the callback param makes it pretty clear that this is async,
so a shorter name is probably better.

[igorcov, 2017/03/09 12:22:57]

Done.

+      const std::string& method_name,

[Daniel Erat, 2017/03/06 21:18:26]

i think that this leaks too many of the IPC implementation details to the
caller. please add separate methods for updating and removing that take the
concrete protobuf type instead of this generic version.

[igorcov, 2017/03/09 12:22:57]

Done.

+      const google::protobuf::MessageLite& request,
+      const ProtobufMethodCallback& callback) = 0;
+
  protected:
   // Create() should be used instead.
   CryptohomeClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CryptohomeClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_CRYPTOHOME_CLIENT_H_