Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.h

Issue 2727713003: Update FWMP in TPM (Closed)
Patch Set: Test fixed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.h
diff --git a/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.h b/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.h
index 5dfada546c763ff65cc1d1c2c95342c595885949..240f72c8ff2159398c74c9783e42de76b6fa4692 100644
--- a/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.h
+++ b/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.h
@@ -16,6 +16,12 @@
#include "chrome/browser/chromeos/policy/auto_enrollment_client.h"
#include "chrome/browser/chromeos/settings/device_settings_service.h"
+namespace cryptohome {
+
Daniel Erat 2017/03/06 21:18:25 nit: i think we usually omit these blank lines whe
Andrew T Wilson (Slow) 2017/03/07 11:16:30 nit: this is OK as-is, but typically I avoid blank
igorcov 2017/03/09 12:22:57 Done.
+class BaseReply;
+
+} // namespace cryptohome
+
namespace chromeos {
// Drives the forced re-enrollment check (for historical reasons called
@@ -86,6 +92,15 @@ class AutoEnrollmentController {
// Sets |state_| and notifies |progress_callbacks_|.
void UpdateState(policy::AutoEnrollmentState state);
+ // D-Bus call to cryptohome to remove the firmware management parameters from
Daniel Erat 2017/03/06 21:18:25 nit: "Makes a D-Bus call ..."
igorcov 2017/03/09 12:22:56 Done.
+ // TPM.
+ void RemoveFwmp();
Daniel Erat 2017/03/06 21:18:25 mind also renaming this to RemoveFirmwareManagemen
igorcov 2017/03/09 12:22:57 Done.
+
+ // Callback after the firmware management parameters is removed.
Daniel Erat 2017/03/06 21:18:25 nit: s/is/are/, but maybe just: // Callback for R
Andrew T Wilson (Slow) 2017/03/07 11:16:30 nit: is->are
igorcov 2017/03/09 12:22:56 Done.
+ void OnFwmpRemoved(chromeos::DBusMethodCallStatus call_status,
Daniel Erat 2017/03/06 21:18:25 ditto here
igorcov 2017/03/09 12:22:57 Done.
+ bool result,
+ const cryptohome::BaseReply& reply);
+
// Handles timeout of the safeguard timer and stops waiting for a result.
void Timeout();

Powered by Google App Engine
This is Rietveld 408576698