Update FWMP in TPM

chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_ENROLLMENT_AUTO_ENROLLMENT_CONTROLLER_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_ENROLLMENT_AUTO_ENROLLMENT_CONTROLLER_H_
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/callback_list.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/timer/timer.h"
 #include "chrome/browser/chromeos/policy/auto_enrollment_client.h"
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
 
+namespace cryptohome {
+

[Daniel Erat, 2017/03/06 21:18:25]

nit: i think we usually omit these blank lines when forward-declaring something
in a namespace, e.g.

namespace cryptohome {
class BaseReply;
}  // namespace cryptohome

[Andrew T Wilson (Slow), 2017/03/07 11:16:30]

nit: this is OK as-is, but typically I avoid blank lines in namespace blocks

[igorcov, 2017/03/09 12:22:57]

Done.

+class BaseReply;
+
+}  // namespace cryptohome
+
 namespace chromeos {
 
 // Drives the forced re-enrollment check (for historical reasons called
 // auto-enrollment check), running an AutoEnrollmentClient if appropriate to
 // make a decision.
 class AutoEnrollmentController {
  public:
   typedef base::CallbackList<void(policy::AutoEnrollmentState)>
       ProgressCallbackList;
 
@@ skipping 50 matching lines @@
   // Callback for the ownership status check.
   void OnOwnershipStatusCheckDone(
       DeviceSettingsService::OwnershipStatus status);
 
   // Starts the auto-enrollment client.
   void StartClient(const std::vector<std::string>& state_keys);
 
   // Sets |state_| and notifies |progress_callbacks_|.
   void UpdateState(policy::AutoEnrollmentState state);
 
+  // D-Bus call to cryptohome to remove the firmware management parameters from

[Daniel Erat, 2017/03/06 21:18:25]

nit: "Makes a D-Bus call ..."

[igorcov, 2017/03/09 12:22:56]

Done.

+  // TPM.
+  void RemoveFwmp();

[Daniel Erat, 2017/03/06 21:18:25]

mind also renaming this to RemoveFirmwareManagementParameters?

[igorcov, 2017/03/09 12:22:57]

Done.

+
+  // Callback after the firmware management parameters is removed.

[Daniel Erat, 2017/03/06 21:18:25]

nit: s/is/are/, but maybe just:

// Callback for RemoveFirmwareManagementParameters().

instead?

[Andrew T Wilson (Slow), 2017/03/07 11:16:30]

nit: is->are

[igorcov, 2017/03/09 12:22:56]

Done.

+  void OnFwmpRemoved(chromeos::DBusMethodCallStatus call_status,

[Daniel Erat, 2017/03/06 21:18:25]

ditto here

[igorcov, 2017/03/09 12:22:57]

Done.

+                     bool result,
+                     const cryptohome::BaseReply& reply);
+
   // Handles timeout of the safeguard timer and stops waiting for a result.
   void Timeout();
 
   policy::AutoEnrollmentState state_;
   ProgressCallbackList progress_callbacks_;
 
   std::unique_ptr<policy::AutoEnrollmentClient> client_;
 
   // This timer acts as a belt-and-suspenders safety for the case where one of
   // the asynchronous steps required to make the auto-enrollment decision
   // doesn't come back. Even though in theory they should all terminate, better
   // safe than sorry: There are DBus interactions, an entire network stack etc.
   // - just too many moving pieces to be confident there are no bugs. If
   // something goes wrong, the timer will ensure that a decision gets made
   // eventually, which is crucial to not block OOBE forever. See
   // http://crbug.com/433634 for background.
   base::Timer safeguard_timer_;
 
   // Whether the forced re-enrollment check has to be applied.
   FRERequirement fre_requirement_ = REQUIRED;
 
   base::WeakPtrFactory<AutoEnrollmentController> client_start_weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AutoEnrollmentController);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_ENROLLMENT_AUTO_ENROLLMENT_CONTROLLER_H_