Update FWMP in TPM

chromeos/dbus/cryptohome_client.h

Index: chromeos/dbus/cryptohome_client.h
diff --git a/chromeos/dbus/cryptohome_client.h b/chromeos/dbus/cryptohome_client.h
index 8fc61f94b0e4f64241a565479d13f9aad0ed5e41..801a766828123a4928cbcc1f619273e6f489a047 100644
--- a/chromeos/dbus/cryptohome_client.h
+++ b/chromeos/dbus/cryptohome_client.h
@@ -27,8 +27,10 @@ class FlushAndSignBootAttributesRequest;
 class GetBootAttributeRequest;
 class GetKeyDataRequest;
 class MountRequest;
+class RemoveFirmwareManagementParametersRequest;
 class RemoveKeyRequest;
 class SetBootAttributeRequest;
+class SetFirmwareManagementParametersRequest;
 class UpdateKeyRequest;
 
 class Identification;
@@ -555,6 +557,22 @@ class CHROMEOS_EXPORT CryptohomeClient : public DBusClient {
       const cryptohome::FlushAndSignBootAttributesRequest& request,
       const ProtobufMethodCallback& callback) = 0;
 
+  // Asynchronously calls RemoveFirmwareManagementParameters method. |callback|
+  // is called after method call, and with reply protobuf.
+  // RemoveFirmwareManagementParameters removes the firmware management
+  // parameters from TPM.
+  virtual void RemoveFirmwareManagementParametersInTpm(

[Thiemo Nagel, 2017/03/23 17:23:52]

Nit: FromTpm would probably be better language.

[igorcov, 2017/03/24 13:29:15]

Done.

+      const cryptohome::RemoveFirmwareManagementParametersRequest& request,

[Thiemo Nagel, 2017/03/23 17:23:52]

The request parameter seems to serve no purpose.  Can we drop it?

[igorcov, 2017/03/24 13:29:15]

It is used, being passed to cryptohome_proxy for CallMethod. Do you suggest
creating it inside this function? It would look different from other functions
and also at risk of changing back to this state in case some parameter inside
the |request| will be added in the future.

+      const ProtobufMethodCallback& callback) = 0;
+
+  // Asynchronously calls SetFirmwareManagementParameters method. |callback|
+  // is called after method call, and with reply protobuf. |request| contains
+  // the flags to be set. SetFirmwareManagementParameters creates the firmware
+  // management parameters in TPM and sets flags included in the request.
+  virtual void SetFirmwareManagementParametersInTpm(
+      const cryptohome::SetFirmwareManagementParametersRequest& request,
+      const ProtobufMethodCallback& callback) = 0;
+
  protected:
   // Create() should be used instead.
   CryptohomeClient();