Update FWMP in TPM

chromeos/dbus/cryptohome_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_CRYPTOHOME_CLIENT_H_
 #define CHROMEOS_DBUS_CRYPTOHOME_CLIENT_H_
 
 #include <stdint.h>
 
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "chromeos/attestation/attestation_constants.h"
 #include "chromeos/chromeos_export.h"
 #include "chromeos/dbus/dbus_client.h"
 #include "chromeos/dbus/dbus_method_call_status.h"
 
 namespace cryptohome {
 
 class AddKeyRequest;
 class AuthorizationRequest;
 class BaseReply;
 class CheckKeyRequest;
 class FlushAndSignBootAttributesRequest;
 class GetBootAttributeRequest;
 class GetKeyDataRequest;
 class MountRequest;
+class RemoveFirmwareManagementParametersRequest;
 class RemoveKeyRequest;
 class SetBootAttributeRequest;
+class SetFirmwareManagementParametersRequest;
 class UpdateKeyRequest;
 
 class Identification;
 
 } // namespace cryptohome
 
 namespace chromeos {
 
 // CryptohomeClient is used to communicate with the Cryptohome service.
 // All method should be called from the origin thread (UI thread) which
@@ skipping 506 matching lines @@
 
   // Asynchronously calls FlushAndSignBootAttributes method. |callback| is
   // called after method call, and with reply protobuf.
   // FlushAndSignBootAttributes makes all pending boot attribute settings
   // available, and have them signed by a special TPM key. This method always
   // fails after any user, publuc, or guest session starts.
   virtual void FlushAndSignBootAttributes(
       const cryptohome::FlushAndSignBootAttributesRequest& request,
       const ProtobufMethodCallback& callback) = 0;
 
+  // Asynchronously calls RemoveFirmwareManagementParameters method. |callback|
+  // is called after method call, and with reply protobuf.
+  // RemoveFirmwareManagementParameters removes the firmware management
+  // parameters from TPM.
+  virtual void RemoveFirmwareManagementParametersInTpm(

[Thiemo Nagel, 2017/03/23 17:23:52]

Nit: FromTpm would probably be better language.

[igorcov, 2017/03/24 13:29:15]

Done.

+      const cryptohome::RemoveFirmwareManagementParametersRequest& request,

[Thiemo Nagel, 2017/03/23 17:23:52]

The request parameter seems to serve no purpose.  Can we drop it?

[igorcov, 2017/03/24 13:29:15]

It is used, being passed to cryptohome_proxy for CallMethod. Do you suggest
creating it inside this function? It would look different from other functions
and also at risk of changing back to this state in case some parameter inside
the |request| will be added in the future.

+      const ProtobufMethodCallback& callback) = 0;
+
+  // Asynchronously calls SetFirmwareManagementParameters method. |callback|
+  // is called after method call, and with reply protobuf. |request| contains
+  // the flags to be set. SetFirmwareManagementParameters creates the firmware
+  // management parameters in TPM and sets flags included in the request.
+  virtual void SetFirmwareManagementParametersInTpm(
+      const cryptohome::SetFirmwareManagementParametersRequest& request,
+      const ProtobufMethodCallback& callback) = 0;
+
  protected:
   // Create() should be used instead.
   CryptohomeClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CryptohomeClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_CRYPTOHOME_CLIENT_H_