Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2727713002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
Mathieu
CC:
Evan Stade, chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, oshima+watch_chromium.org, pkl (ping after 24h if needed), rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, donnd+watch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, noyau+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, marq+watch_chromium.org, Jered, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (autofill, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=mathp@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2727713002 Cr-Commit-Position: refs/heads/master@{#454052} Committed: https://chromium.googlesource.com/chromium/src/+/5365d82f364358e15dec8fe8c07a95cf2c17412b

Patch Set 1 : Add TEAM/COMPONENT #

Total comments: 10

Patch Set 2 : update component/team #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M chrome/browser/autofill/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/local_ntp/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/search/suggestions/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/autofill/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/image_fetcher/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/leveldb_proto/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/suggestions/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/test/data/autofill/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/suggestions/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/webui/resources/roboto/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-01 19:14:01 UTC) #3
Mathieu
https://codereview.chromium.org/2727713002/diff/20001/chrome/browser/search/suggestions/OWNERS File chrome/browser/search/suggestions/OWNERS (right): https://codereview.chromium.org/2727713002/diff/20001/chrome/browser/search/suggestions/OWNERS#newcode4 chrome/browser/search/suggestions/OWNERS:4: # COMPONENT: UI>Browser>Search UI>Browser>NewTabPage https://codereview.chromium.org/2727713002/diff/20001/components/image_fetcher/OWNERS File components/image_fetcher/OWNERS (right): https://codereview.chromium.org/2727713002/diff/20001/components/image_fetcher/OWNERS#newcode5 ...
3 years, 9 months ago (2017-03-01 19:19:59 UTC) #4
ymzhang1
https://codereview.chromium.org/2727713002/diff/20001/chrome/browser/search/suggestions/OWNERS File chrome/browser/search/suggestions/OWNERS (right): https://codereview.chromium.org/2727713002/diff/20001/chrome/browser/search/suggestions/OWNERS#newcode4 chrome/browser/search/suggestions/OWNERS:4: # COMPONENT: UI>Browser>Search On 2017/03/01 19:19:58, Mathieu Perreault wrote: ...
3 years, 9 months ago (2017-03-01 19:25:43 UTC) #5
Mathieu
lgtm
3 years, 9 months ago (2017-03-01 20:50:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727713002/40001
3 years, 9 months ago (2017-03-01 20:52:47 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 21:58:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5365d82f364358e15dec8fe8c07a...

Powered by Google App Engine
This is Rietveld 408576698