Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2727703002: [CacheStorageCache] Close Entry* if the CacheStorageCache is gone (Closed)

Created:
3 years, 9 months ago by jkarlin
Modified:
3 years, 9 months ago
Reviewers:
jsbell
CC:
chromium-reviews, jam, darin-cc_chromium.org, jkarlin+watch_chromium.org, nhiroki
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CacheStorageCache] Close Entry* if the CacheStorageCache is gone BUG=697507 Review-Url: https://codereview.chromium.org/2727703002 Cr-Commit-Position: refs/heads/master@{#454000} Committed: https://chromium.googlesource.com/chromium/src/+/06f7d73f2487d1e57b56117811735c002b90bc33

Patch Set 1 #

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/browser/cache_storage/cache_storage_cache.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
jkarlin
jsbell@ PTAL, thanks!
3 years, 9 months ago (2017-03-01 18:32:47 UTC) #4
jsbell
lgtm (Would be nice to have a holder type wrapping Entry objects that calls Close() ...
3 years, 9 months ago (2017-03-01 18:57:31 UTC) #7
jkarlin
Thanks! Agree with your comment, btw. That's a good future task.
3 years, 9 months ago (2017-03-01 19:00:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727703002/20001
3 years, 9 months ago (2017-03-01 19:00:57 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 19:46:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/06f7d73f2487d1e57b5611781173...

Powered by Google App Engine
This is Rietveld 408576698