Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2727693003: MD Settings: Input method: add show-in-shelf toggle (Closed)

Created:
3 years, 9 months ago by stevenjb
Modified:
3 years, 9 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Input method: add show-in-shelf toggle BUG=694928 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2727693003 Cr-Commit-Position: refs/heads/master@{#454126} Committed: https://chromium.googlesource.com/chromium/src/+/c0e297639ffe51b7a3fc75fe96f9a1fb832a0ea1

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.html View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
stevenjb
3 years, 9 months ago (2017-03-01 23:18:56 UTC) #3
hcarmona
LGTM w/ a nit: please add a screenshot to the bug
3 years, 9 months ago (2017-03-01 23:29:17 UTC) #4
stevenjb
On 2017/03/01 23:29:17, hcarmona wrote: > LGTM w/ a nit: please add a screenshot to ...
3 years, 9 months ago (2017-03-01 23:34:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727693003/20001
3 years, 9 months ago (2017-03-01 23:34:56 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 00:45:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c0e297639ffe51b7a3fc75fe96f9...

Powered by Google App Engine
This is Rietveld 408576698