Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2727673003: Clean up: Name is always not empty in SharedMemory on Windows (Closed)

Created:
3 years, 9 months ago by hajimehoshi
Modified:
3 years, 9 months ago
Reviewers:
danakj
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up: Name is always not empty in SharedMemory on Windows When creating a file map object, its name is indicated in any cases. This CL removes redundant name check for code health. BUG=n/a TEST=n/a Review-Url: https://codereview.chromium.org/2727673003 Cr-Commit-Position: refs/heads/master@{#454284} Committed: https://chromium.googlesource.com/chromium/src/+/df47eddfc5482633bf4612576fd096b7e67cc496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M base/memory/shared_memory_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
hajimehoshi
PTAL
3 years, 9 months ago (2017-03-02 11:11:23 UTC) #4
danakj
LGTM
3 years, 9 months ago (2017-03-02 15:40:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727673003/1
3 years, 9 months ago (2017-03-02 16:41:01 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 16:48:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df47eddfc5482633bf4612576fd0...

Powered by Google App Engine
This is Rietveld 408576698