Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2727663006: MD WebUI: change how initial focus works in <dialog>s now that they know about shadow DOM (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
dpapad
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: change how initial focus works in <dialog>s now that they know about shadow DOM R=dpapad@chromium.org BUG=697338 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2727663006 Cr-Commit-Position: refs/heads/master@{#454064} Committed: https://chromium.googlesource.com/chromium/src/+/b219d44719985ddfd613cfdb95e7aca9cf005e9c

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M chrome/test/data/webui/cr_elements/cr_dialog_test.js View 1 2 chunks +16 lines, -10 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Dan Beam
3 years, 9 months ago (2017-03-01 19:34:04 UTC) #2
dpapad
There is a related test failure at https://cs.chromium.org/chromium/src/chrome/test/data/webui/cr_elements/cr_dialog_test.js?l=22. Is this test obsolete after this CL, ...
3 years, 9 months ago (2017-03-01 20:16:20 UTC) #5
Dan Beam
On 2017/03/01 20:16:20, dpapad wrote: > There is a related test failure at > https://cs.chromium.org/chromium/src/chrome/test/data/webui/cr_elements/cr_dialog_test.js?l=22. ...
3 years, 9 months ago (2017-03-01 20:24:23 UTC) #8
dpapad
lgtm
3 years, 9 months ago (2017-03-01 20:27:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727663006/20001
3 years, 9 months ago (2017-03-01 20:31:17 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 22:16:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b219d44719985ddfd613cfdb95e7...

Powered by Google App Engine
This is Rietveld 408576698