Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2727643011: Skip failing test suites on the GPU FYI TSAN bot. (Closed)

Created:
3 years, 9 months ago by danakj
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip failing test suites on the GPU FYI TSAN bot. This adds an 'instrumentation_type' field to the TSAN bot and checks for 'disabled_instrumentation_types' field for each test suite. If both are present and the disabled type is the bot's type, then the test suite is skipped. R=kbr@chromium.org BUG=691029 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2727643011 Cr-Commit-Position: refs/heads/master@{#454718} Committed: https://chromium.googlesource.com/chromium/src/+/0cf54c3293b5ed38cbfeedcbf8b8108d9bd25f6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -318 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 15 chunks +19 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 2 chunks +0 lines, -318 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
danakj
3 years, 9 months ago (2017-03-03 22:45:34 UTC) #5
Ken Russell (switch to Gerrit)
Thank you Dana! LGTM.
3 years, 9 months ago (2017-03-03 23:48:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727643011/1
3 years, 9 months ago (2017-03-03 23:52:07 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-04 00:00:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0cf54c3293b5ed38cbfeedcbf8b8...

Powered by Google App Engine
This is Rietveld 408576698