Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2727643010: InternetPageTest: flush dom after interactions (Closed)

Created:
3 years, 9 months ago by stevenjb
Modified:
3 years, 9 months ago
Reviewers:
michaelpg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

InternetPageTest: flush dom after interactions MockInteractions does not flush the DOM, so even though we call testing.Test.disableAnimationsAndTransitions() in suiteSetup, the subpage may not be populated immediately after a tap event. BUG=698109 Review-Url: https://codereview.chromium.org/2727643010 Cr-Commit-Position: refs/heads/master@{#454691} Committed: https://chromium.googlesource.com/chromium/src/+/ae62c32ff5a0da751cf186a97a9d2f2ff4552d6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/test/data/webui/settings/internet_page_tests.js View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
stevenjb
This is short, PTAL and LMKWYT as soon as as you have a chance - ...
3 years, 9 months ago (2017-03-03 17:35:16 UTC) #2
michaelpg
lgtm
3 years, 9 months ago (2017-03-03 21:32:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727643010/1
3 years, 9 months ago (2017-03-03 21:32:55 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 22:34:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae62c32ff5a0da751cf186a97a9d...

Powered by Google App Engine
This is Rietveld 408576698