Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2727633006: DevTools: Rename InspectorInstrumentation:: namespace into probe:: (Closed)

Created:
3 years, 9 months ago by alph
Modified:
3 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, shans, szager+layoutwatch_chromium.org, tzik, webcomponents-bugzilla_chromium.org, dshwang, eae+blinkwatch, dcheng, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, kinuko+worker_chromium.org, kinuko+watch, rwlbuis, timvolodine, caseq+blink_chromium.org, awdf+watch_chromium.org, mvanouwerkerk+watch_chromium.org, yhirano+watch_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, blink-reviews, falken+watch_chromium.org, blink-worker-reviews_chromium.org, Eric Willigers, rjwright, blink-reviews-style_chromium.org, zoltan1, Peter Beverloo, blink-reviews-paint_chromium.org, blink-reviews-layout_chromium.org, sof, Yoav Weiss, nhiroki, lushnikov+blink_chromium.org, darktears, haraken, jsbell+idb_chromium.org, mlamouri+watch-blink_chromium.org, michaeln, tyoshino+watch_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, shimazu+worker_chromium.org, pfeldman+blink_chromium.org, cmumford, horo+watch_chromium.org, blink-reviews-frames_chromium.org, kinuko+fileapi, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Rename InspectorInstrumentation:: namespace into probe:: BUG=695625 NOTRY=true Review-Url: https://codereview.chromium.org/2727633006 Cr-Commit-Position: refs/heads/master@{#454460} Committed: https://chromium.googlesource.com/chromium/src/+/9d8c99cfe73e17fccae5512ef7abf38381370a17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -395 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CharacterData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 8 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserver.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PseudoElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadowV0.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp View 4 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/GenericEventQueue.cpp View 4 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/PerformanceMonitor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 8 chunks +16 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 13 chunks +18 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ProgressTracker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/CreateWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/DocumentXSLT.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 7 chunks +12 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/eventsource/EventSource.cpp View 5 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 5 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileWriter.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp View 13 chunks +15 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp View 4 chunks +7 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 12 chunks +22 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
alph
3 years, 9 months ago (2017-03-02 23:40:53 UTC) #4
pfeldman
lgtm
3 years, 9 months ago (2017-03-02 23:59:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727633006/1
3 years, 9 months ago (2017-03-03 01:28:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727633006/1
3 years, 9 months ago (2017-03-03 01:29:10 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 01:46:46 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d8c99cfe73e17fccae5512ef7ab...

Powered by Google App Engine
This is Rietveld 408576698