Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 272763005: Add default options for ThreadSanitizer on Linux. Enable deadlock detection by default. (Closed)

Created:
6 years, 7 months ago by Alexander Potapenko
Modified:
6 years, 7 months ago
Reviewers:
earthdok
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Add default options for ThreadSanitizer on Linux. Enable deadlock detection by default. BUG=372754, 302040 R=earthdok@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271412

Patch Set 1 #

Patch Set 2 : print the second deadlock stack #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M base/debug/sanitizer_options.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Alexander Potapenko
PTAL
6 years, 7 months ago (2014-05-16 13:04:56 UTC) #1
earthdok
lgtm
6 years, 7 months ago (2014-05-16 14:37:45 UTC) #2
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 7 months ago (2014-05-19 12:06:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/272763005/60001
6 years, 7 months ago (2014-05-19 12:06:24 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 14:01:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 15:03:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/28393)
6 years, 7 months ago (2014-05-19 15:03:19 UTC) #7
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 7 months ago (2014-05-19 16:16:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/272763005/60001
6 years, 7 months ago (2014-05-19 16:16:48 UTC) #9
commit-bot: I haz the power
Change committed as 271412
6 years, 7 months ago (2014-05-19 17:25:01 UTC) #10
Jeffrey Yasskin
6 years, 7 months ago (2014-05-19 19:07:06 UTC) #11
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/287373004/ by jyasskin@chromium.org.

The reason for reverting is: The linux_clan_tsan trybot caught a few deadlock
reports that break memory bots after this change. 

e.g.
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28T...
.

Powered by Google App Engine
This is Rietveld 408576698