Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2727593003: Fix incorrect use of unique_ptr found by PVS-Studio (Closed)

Created:
3 years, 9 months ago by brucedawson
Modified:
3 years, 9 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect use of unique_ptr found by PVS-Studio A run of PVS-Studio on Chrome reported various warnings including: V554 Incorrect use of unique_ptr. The memory allocated with 'new []' will be cleaned using 'delete'. install_util.cc 500 R=grt@chromium.org BUG=697659 Review-Url: https://codereview.chromium.org/2727593003 Cr-Commit-Position: refs/heads/master@{#454555} Committed: https://chromium.googlesource.com/chromium/src/+/e9dbe4d1324caf643ae7808a875c6fad254555a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/install_static/install_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
brucedawson
PTAL
3 years, 9 months ago (2017-03-02 00:57:10 UTC) #5
grt (UTC plus 2)
lgtm Thanks!
3 years, 9 months ago (2017-03-03 09:32:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727593003/1
3 years, 9 months ago (2017-03-03 09:33:05 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 10:07:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e9dbe4d1324caf643ae7808a875c...

Powered by Google App Engine
This is Rietveld 408576698