Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2727583003: android: Comment to implement DidSwapBuffers for vulkan (Closed)

Created:
3 years, 9 months ago by boliu
Modified:
3 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Comment to implement DidSwapBuffers for vulkan To match GL path and implement DidSwapBuffers. Right now there isn't a way to even build android with vulkan enabled, so not bothering to write the code now, and just adding a TODO. BUG=664530, 582558 Review-Url: https://codereview.chromium.org/2727583003 Cr-Commit-Position: refs/heads/master@{#454659} Committed: https://chromium.googlesource.com/chromium/src/+/1021ed20bd0720753b316270561c691e26f93cf7

Patch Set 1 #

Patch Set 2 : bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/renderer_host/compositor_impl_android.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
boliu
ptal
3 years, 9 months ago (2017-03-01 19:35:40 UTC) #2
aelias_OOO_until_Jul13
Can you file a crbug on it and mention the crbug in the comment?
3 years, 9 months ago (2017-03-01 20:00:51 UTC) #3
boliu
On 2017/03/01 20:00:51, aelias wrote: > Can you file a crbug on it and mention ...
3 years, 9 months ago (2017-03-03 17:16:28 UTC) #5
aelias_OOO_until_Jul13
lgtm
3 years, 9 months ago (2017-03-03 19:21:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727583003/20001
3 years, 9 months ago (2017-03-03 19:38:19 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 20:14:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1021ed20bd0720753b316270561c...

Powered by Google App Engine
This is Rietveld 408576698