Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 2727583002: Desktop error bubble should be yellow. (Closed)

Created:
3 years, 9 months ago by Alexander Alekseev
Modified:
3 years, 9 months ago
Reviewers:
xiyuan, jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Desktop error bubble should be yellow. This CL limits white error bubble added in https://codereview.chromium.org/2467783002 to ChromeOS only. BUG=642400 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2727583002 Cr-Commit-Position: refs/heads/master@{#453978} Committed: https://chromium.googlesource.com/chromium/src/+/c55c4ef894a6871a79f318c43f211f0e81105a76

Patch Set 1 #

Patch Set 2 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M chrome/browser/resources/chromeos/login/lock.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/login.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/login/bubble.css View 1 4 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Alexander Alekseev
Please review.
3 years, 9 months ago (2017-03-01 05:32:55 UTC) #3
xiyuan
lgtm
3 years, 9 months ago (2017-03-01 17:32:04 UTC) #8
jdufault
lgtm
3 years, 9 months ago (2017-03-01 17:56:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727583002/20001
3 years, 9 months ago (2017-03-01 18:33:38 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c55c4ef894a6871a79f318c43f211f0e81105a76
3 years, 9 months ago (2017-03-01 18:39:43 UTC) #14
Alexander Alekseev
3 years, 9 months ago (2017-03-01 20:06:45 UTC) #15
Message was sent while issue was closed.
This should be attributed to
https://bugs.chromium.org/p/chromium/issues/detail?id=664925

Powered by Google App Engine
This is Rietveld 408576698