Fix rendering functions of "properties" of an api object

Fix rendering functions of "properties" of an api object

There aren't many api properties that have functions, so this wasn't
thoroughly checked I'm assuming. accessibilityFeatures has one such
example.

Rendering <table> content (body) without <tr> is bad idea, it messes
up rendering the table. What happens in the broken case for
accessibilityFeatures is that rows (2nd and onwards) are pushed out of
table t1 below:
<table id="t1">
  <tr><td>
    <table id="t2"> <!-- no tr/td -->
      <table><tr><td>A</td></tr></table>
    </table>
  </td></tr>
  <tr><td>This row will be pushed out of t1</td></tr>
</table>

Live example can be seen at:
http://lazyboy.github.io/pages/markup/valid_table.html
http://lazyboy.github.io/pages/markup/invalid_table.html

Therefore this CL wraps function template with <tr><td> when called
from api_property template. The function template already have
condition to add <tr><td> though, based on parentName param. However
there are cases where we want to preserve that (api_property template).
It seemed safer to me to wrap the callsite.

BUG=693255
Test=Check largeCursor documentation in
https://developer.chrome.com/apps/accessibilityFeatures#property-largeCursor
The entry should be rendered within a table.

Review-Url: https://codereview.chromium.org/2727573006
Cr-Commit-Position: refs/heads/master@{#456950}
Committed: https://chromium.googlesource.com/chromium/src/+/2691c6929de42bf5845162fe9df31270c9b38b18

[lazyboy, 2017-03-03 02:26:35]

Description was changed from

==========
Fix rendering functions inside api properties.

There aren't many api properties that have functions, so this wasn't
thoroughly checked I'm assuming. accessibilityFeatures has one such
example.

Rendering <table> content (body) without <tr> is bad idea, it messes
up rendering the table. What happens in the broken case for
accessibilityFeatures is that rows (2nd and onwards) are pushed out of
table t1 below:
<table id="t1">
  <tr><td>
    <table id="t2"> <!-- no tr/td -->
      <table><tr><td>A</td></tr></table>
    </table>
  </td></tr>
  <tr><td>This row will be pushed out of t1</td></tr>
</table>

Live example can be seen at:
http://lazyboy.github.io/pages/markup/valid_table.html
http://lazyboy.github.io/pages/markup/invalid_table.html

Therefore this CL wraps function template with <tr><td> when called
from api_property template. The function template already have
condition to add <tr><td> though, based on parentName param. However
there are cases where we want to preserve that (api_property template).
It seemed safer to me to wrap the callsite.

BUG=693255
Test=Check largeCursor documentation in
https://developer.chrome.com/apps/accessibilityFeatures#property-largeCursor
The entry should be rendered within a table.
==========

to

==========
Fix rendering functions of "properties" of an api object

There aren't many api properties that have functions, so this wasn't
thoroughly checked I'm assuming. accessibilityFeatures has one such
example.

Rendering <table> content (body) without <tr> is bad idea, it messes
up rendering the table. What happens in the broken case for
accessibilityFeatures is that rows (2nd and onwards) are pushed out of
table t1 below:
<table id="t1">
  <tr><td>
    <table id="t2"> <!-- no tr/td -->
      <table><tr><td>A</td></tr></table>
    </table>
  </td></tr>
  <tr><td>This row will be pushed out of t1</td></tr>
</table>

Live example can be seen at:
http://lazyboy.github.io/pages/markup/valid_table.html
http://lazyboy.github.io/pages/markup/invalid_table.html

Therefore this CL wraps function template with <tr><td> when called
from api_property template. The function template already have
condition to add <tr><td> though, based on parentName param. However
there are cases where we want to preserve that (api_property template).
It seemed safer to me to wrap the callsite.

BUG=693255
Test=Check largeCursor documentation in
https://developer.chrome.com/apps/accessibilityFeatures#property-largeCursor
The entry should be rendered within a table.
==========

[lazyboy, 2017-03-03 02:27:34]

lazyboy@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2017-03-03 19:35:37]

lgtm, nice!

[lazyboy, 2017-03-04 01:27:56]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-04 01:28:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 01:38:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 01:38:10]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lazyboy, 2017-03-15 01:48:20]

The CQ bit was checked by lazyboy@chromium.org

[commit-bot: I haz the power, 2017-03-15 01:49:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 02:10:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489542500759610, "parent_rev":
"e0604382f6f7580f4421387f35ef2fe559ab107b", "commit_rev":
"2691c6929de42bf5845162fe9df31270c9b38b18"}

[commit-bot: I haz the power, 2017-03-15 02:11:39]

Description was changed from

==========
Fix rendering functions of "properties" of an api object

There aren't many api properties that have functions, so this wasn't
thoroughly checked I'm assuming. accessibilityFeatures has one such
example.

Rendering <table> content (body) without <tr> is bad idea, it messes
up rendering the table. What happens in the broken case for
accessibilityFeatures is that rows (2nd and onwards) are pushed out of
table t1 below:
<table id="t1">
  <tr><td>
    <table id="t2"> <!-- no tr/td -->
      <table><tr><td>A</td></tr></table>
    </table>
  </td></tr>
  <tr><td>This row will be pushed out of t1</td></tr>
</table>

Live example can be seen at:
http://lazyboy.github.io/pages/markup/valid_table.html
http://lazyboy.github.io/pages/markup/invalid_table.html

Therefore this CL wraps function template with <tr><td> when called
from api_property template. The function template already have
condition to add <tr><td> though, based on parentName param. However
there are cases where we want to preserve that (api_property template).
It seemed safer to me to wrap the callsite.

BUG=693255
Test=Check largeCursor documentation in
https://developer.chrome.com/apps/accessibilityFeatures#property-largeCursor
The entry should be rendered within a table.
==========

to

==========
Fix rendering functions of "properties" of an api object

There aren't many api properties that have functions, so this wasn't
thoroughly checked I'm assuming. accessibilityFeatures has one such
example.

Rendering <table> content (body) without <tr> is bad idea, it messes
up rendering the table. What happens in the broken case for
accessibilityFeatures is that rows (2nd and onwards) are pushed out of
table t1 below:
<table id="t1">
  <tr><td>
    <table id="t2"> <!-- no tr/td -->
      <table><tr><td>A</td></tr></table>
    </table>
  </td></tr>
  <tr><td>This row will be pushed out of t1</td></tr>
</table>

Live example can be seen at:
http://lazyboy.github.io/pages/markup/valid_table.html
http://lazyboy.github.io/pages/markup/invalid_table.html

Therefore this CL wraps function template with <tr><td> when called
from api_property template. The function template already have
condition to add <tr><td> though, based on parentName param. However
there are cases where we want to preserve that (api_property template).
It seemed safer to me to wrap the callsite.

BUG=693255
Test=Check largeCursor documentation in
https://developer.chrome.com/apps/accessibilityFeatures#property-largeCursor
The entry should be rendered within a table.

Review-Url: https://codereview.chromium.org/2727573006
Cr-Commit-Position: refs/heads/master@{#456950}
Committed:
https://chromium.googlesource.com/chromium/src/+/2691c6929de42bf5845162fe9df3...
==========

[commit-bot: I haz the power, 2017-03-15 02:11:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2691c6929de42bf5845162fe9df3...