Remove useless DCHECK; discard helper enforces invalid values.

Remove useless DCHECK; discard helper enforces invalid values.

This DCHECK is harmless and failure of it just means we'll discard
a bit less of a negative packet than expected. Invalid values are
already sanitized by AudioDiscardHelper.

Also fixes log spam from duration changes.

BUG=697299
TEST=fuzzertest no longer fails.

Review-Url: https://codereview.chromium.org/2727573005
Cr-Commit-Position: refs/heads/master@{#454430}
Committed: https://chromium.googlesource.com/chromium/src/+/e24ee9fad5abcc31826978860d91047c8e6aa25f

[DaleCurtis, 2017-03-02 20:52:31]

dalecurtis@chromium.org changed reviewers:
+ chcunningham@chromium.org

[DaleCurtis, 2017-03-02 20:53:24]

Description was changed from

==========
Remove useless DCHECK; discard helper enforces invalid values.

This DCHECK is harmless and failure of it just means we'll discard
a bit less of a negative packet than expected. Invalid values are
already sanitized by DiscardHelper.

Also fixes log spam from duration changes.

BUG=697299
TEST=fuzzertest no longer fails.
==========

to

==========
Remove useless DCHECK; discard helper enforces invalid values.

This DCHECK is harmless and failure of it just means we'll discard
a bit less of a negative packet than expected. Invalid values are
already sanitized by AudioDiscardHelper.

Also fixes log spam from duration changes.

BUG=697299
TEST=fuzzertest no longer fails.
==========

[chcunningham, 2017-03-02 21:45:59]

LGTM

Just to be sure I'm reading it right, in the even that codec delay is not enough
to cover the negative timestamp, we will simply decode the amount described by
codec delay and rebase anything after that to 0. Right?

[DaleCurtis, 2017-03-02 21:54:20]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2017-03-02 21:54:20]

We will decode the data which was below 0 and only drop |codec_delay| frames
from it. The DCHECK was there to ensure that |time_below_zero| <= |codec_delay|
so it would all be dropped. However this is apparently not always true given the
cluster fuzz failure; so we'll end up rendering some audio that normally is
supposed to be dropped.

I don't think this warrants a failure; the discard helper will ensure we have
sane values for codec delay and such; and failures just end up with more or less
decoded data.

[commit-bot: I haz the power, 2017-03-02 21:55:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 23:25:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488491660148990, "parent_rev":
"7091f0852e6a60119f3cdbcc7eb34c479bf93fc9", "commit_rev":
"e24ee9fad5abcc31826978860d91047c8e6aa25f"}

[commit-bot: I haz the power, 2017-03-02 23:26:21]

Description was changed from

==========
Remove useless DCHECK; discard helper enforces invalid values.

This DCHECK is harmless and failure of it just means we'll discard
a bit less of a negative packet than expected. Invalid values are
already sanitized by AudioDiscardHelper.

Also fixes log spam from duration changes.

BUG=697299
TEST=fuzzertest no longer fails.
==========

to

==========
Remove useless DCHECK; discard helper enforces invalid values.

This DCHECK is harmless and failure of it just means we'll discard
a bit less of a negative packet than expected. Invalid values are
already sanitized by AudioDiscardHelper.

Also fixes log spam from duration changes.

BUG=697299
TEST=fuzzertest no longer fails.

Review-Url: https://codereview.chromium.org/2727573005
Cr-Commit-Position: refs/heads/master@{#454430}
Committed:
https://chromium.googlesource.com/chromium/src/+/e24ee9fad5abcc31826978860d91...
==========

[commit-bot: I haz the power, 2017-03-02 23:26:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e24ee9fad5abcc31826978860d91...