Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2727563002: Selection API: document.open() should reset Selection. (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Selection API: document.open() should reset Selection. BUG=683066 Review-Url: https://codereview.chromium.org/2727563002 Cr-Commit-Position: refs/heads/master@{#453872} Committed: https://chromium.googlesource.com/chromium/src/+/bff9c922e36599cb97e47c0e8f1f190cc97e69ad

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/editing/editability/empty-document-stylewithcss-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/Document-open-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScope.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScope.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
tkent
yosin@, yoichio@, would you review this please? This CL reduces the number of FAILs in ...
3 years, 9 months ago (2017-03-01 05:21:07 UTC) #7
yosin_UTC9
lgtm Good catch!
3 years, 9 months ago (2017-03-01 05:47:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727563002/20001
3 years, 9 months ago (2017-03-01 06:53:59 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 06:59:12 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bff9c922e36599cb97e47c0e8f1f...

Powered by Google App Engine
This is Rietveld 408576698