Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2727553002: Selection API: Add a UseCounter for focus change by Selection.modify(). (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Selection API: Add a UseCounter for focus change by Selection.modify(). This is a leftover of https://codereview.chromium.org/2718293002/. BUG=690272 Review-Url: https://codereview.chromium.org/2727553002 Cr-Commit-Position: refs/heads/master@{#453867} Committed: https://chromium.googlesource.com/chromium/src/+/c608fa61bc66ef930ee8902f2d154b4d4fd6e7ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tkent
yoichio@, yosin@, would you review this please?
3 years, 9 months ago (2017-03-01 04:19:33 UTC) #4
yosin_UTC9
lgtm
3 years, 9 months ago (2017-03-01 04:51:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727553002/1
3 years, 9 months ago (2017-03-01 06:21:27 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 06:40:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c608fa61bc66ef930ee8902f2d15...

Powered by Google App Engine
This is Rietveld 408576698