Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 2727513002: Revert of MD Settings: Stop using prefs to populate import data dialog. (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MD Settings: Stop using prefs to populate import data dialog. (patchset #2 id:20001 of https://codereview.chromium.org/2717013002/ ) Reason for revert: We want to continue respecting policy and master prefs in the importData dialog. Original issue's description: > MD Settings: Stop using prefs to populate import data dialog. > > BUG=695611 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2717013002 > Cr-Commit-Position: refs/heads/master@{#453332} > Committed: https://chromium.googlesource.com/chromium/src/+/5a915bf6d281b1142802a87491a1d17e811f3a8b TBR=dpapad@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=695611 Review-Url: https://codereview.chromium.org/2727513002 Cr-Commit-Position: refs/heads/master@{#453821} Committed: https://chromium.googlesource.com/chromium/src/+/b1e4703e6fd4ba6bff38cc6d4d7a6c2945987141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -68 lines) Patch
M chrome/browser/resources/settings/people_page/import_data_dialog.html View 5 chunks +31 lines, -35 lines 0 comments Download
M chrome/browser/resources/settings/people_page/import_data_dialog.js View 4 chunks +14 lines, -16 lines 0 comments Download
M chrome/test/data/webui/settings/import_data_dialog_test.js View 4 chunks +22 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dan Beam
Created Revert of MD Settings: Stop using prefs to populate import data dialog.
3 years, 9 months ago (2017-03-01 02:07:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727513002/1
3 years, 9 months ago (2017-03-01 02:08:37 UTC) #3
dpapad
lgtm
3 years, 9 months ago (2017-03-01 02:10:20 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 03:23:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b1e4703e6fd4ba6bff38cc6d4d7a...

Powered by Google App Engine
This is Rietveld 408576698