Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2727443003: MD Settings: Device: fix initialization (Closed)

Created:
3 years, 9 months ago by stevenjb
Modified:
3 years, 9 months ago
Reviewers:
jdufault, michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Device: fix initialization BUG=695201 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2727443003 Cr-Commit-Position: refs/heads/master@{#453856} Committed: https://chromium.googlesource.com/chromium/src/+/186f899c6201f18f98e56c640c97430063906d4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M chrome/browser/resources/settings/device_page/device_page.js View 2 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
stevenjb
jdufault@ - apologies for my hasty review before. Hopefully the comments I added are sufficient.
3 years, 9 months ago (2017-02-28 23:02:45 UTC) #3
jdufault
lgtm
3 years, 9 months ago (2017-02-28 23:32:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727443003/1
3 years, 9 months ago (2017-03-01 00:20:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/399830)
3 years, 9 months ago (2017-03-01 02:23:42 UTC) #8
michaelpg
lgtm
3 years, 9 months ago (2017-03-01 02:36:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727443003/1
3 years, 9 months ago (2017-03-01 04:59:53 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 05:39:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/186f899c6201f18f98e56c640c97...

Powered by Google App Engine
This is Rietveld 408576698