Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2727393003: [debugger,api] deprecate everything in v8-debug.h (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
CC:
ofrobots, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger,api] deprecate everything in v8-debug.h R=clemensh@chromium.org, jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2727393003 Cr-Commit-Position: refs/heads/master@{#43714} Committed: https://chromium.googlesource.com/v8/v8/+/faf5f52627cdb398cac2f756e79dba042c48d7b2

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comments #

Patch Set 3 : fix #

Patch Set 4 : rebase #

Patch Set 5 : fix #

Patch Set 6 : remove TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -353 lines) Patch
M include/v8-debug.h View 1 2 3 4 5 4 chunks +24 lines, -19 lines 0 comments Download
M src/api.cc View 1 2 3 4 5 5 chunks +32 lines, -37 lines 0 comments Download
M test/cctest/cctest.h View 2 chunks +4 lines, -7 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 3 chunks +14 lines, -7 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 3 4 5 187 chunks +242 lines, -261 lines 0 comments Download
M test/cctest/wasm/test-wasm-breakpoints.cc View 1 2 3 4 5 4 chunks +7 lines, -22 lines 0 comments Download

Messages

Total messages: 32 (19 generated)
Yang
Please take a look.
3 years, 9 months ago (2017-03-03 12:08:36 UTC) #1
jgruber
Awesome! lgtm. Nice to see that the debug delegate is working out. https://codereview.chromium.org/2727393003/diff/1/test/cctest/compiler/test-run-bytecode-graph-builder.cc File test/cctest/compiler/test-run-bytecode-graph-builder.cc ...
3 years, 9 months ago (2017-03-03 12:16:01 UTC) #4
Clemens Hammacher
Very nice! lgtm
3 years, 9 months ago (2017-03-03 13:04:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727393003/20001
3 years, 9 months ago (2017-03-03 13:18:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/14074) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 9 months ago (2017-03-03 13:23:15 UTC) #10
commit-bot: I haz the power
This CL has an open dependency (Issue 2733783002 Patch 1). Please resolve the dependency and ...
3 years, 9 months ago (2017-03-06 10:19:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727393003/60001
3 years, 9 months ago (2017-03-06 11:52:35 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/14131)
3 years, 9 months ago (2017-03-06 11:59:05 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727393003/80001
3 years, 9 months ago (2017-03-06 12:11:38 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/33847)
3 years, 9 months ago (2017-03-06 12:33:43 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727393003/80001
3 years, 9 months ago (2017-03-10 06:35:56 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727393003/100001
3 years, 9 months ago (2017-03-10 06:37:46 UTC) #29
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 07:06:33 UTC) #32
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/faf5f52627cdb398cac2f756e79dba042c4...

Powered by Google App Engine
This is Rietveld 408576698