Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 9 months ago by Yang Modified:
3 years, 9 months ago Reviewers:
Clemens Hammacher, jgruber CC:
ofrobots, v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[debugger,api] deprecate everything in v8-debug.h
R=clemensh@chromium.org, jgruber@chromium.org
BUG=v8:5530
Review-Url: https://codereview.chromium.org/2727393003
Cr-Commit-Position: refs/heads/master@{#43714}
Committed: https://chromium.googlesource.com/v8/v8/+/faf5f52627cdb398cac2f756e79dba042c48d7b2
Patch Set 1 #
Total comments: 1
Patch Set 2 : address comments #Patch Set 3 : fix #Patch Set 4 : rebase #Patch Set 5 : fix #Patch Set 6 : remove TODO #
Created: 3 years, 9 months ago
Messages
Total messages: 32 (19 generated)
Please take a look.
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Awesome! lgtm. Nice to see that the debug delegate is working out. https://codereview.chromium.org/2727393003/diff/1/test/cctest/compiler/test-r... File test/cctest/compiler/test-run-bytecode-graph-builder.cc (right): https://codereview.chromium.org/2727393003/diff/1/test/cctest/compiler/test-r... test/cctest/compiler/test-run-bytecode-graph-builder.cc:2974: v8::Local<v8::Value> break_points_hit) { Nit: override
Very nice! lgtm
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org Link to the patchset: https://codereview.chromium.org/2727393003/#ps20001 (title: "address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/18432)
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from clemensh@chromium.org, jgruber@chromium.org Link to the patchset: https://codereview.chromium.org/2727393003/#ps40001 (title: "fix")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2733783002 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from clemensh@chromium.org, jgruber@chromium.org Link to the patchset: https://codereview.chromium.org/2727393003/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from clemensh@chromium.org, jgruber@chromium.org Link to the patchset: https://codereview.chromium.org/2727393003/#ps80001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from clemensh@chromium.org, jgruber@chromium.org Link to the patchset: https://codereview.chromium.org/2727393003/#ps100001 (title: "remove TODO")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489127855868760,
"parent_rev": "a3a244cb8704a7087c542a01ae591c07f18785ea", "commit_rev":
"faf5f52627cdb398cac2f756e79dba042c48d7b2"}
Message was sent while issue was closed.
Description was changed from ========== [debugger,api] deprecate everything in v8-debug.h R=clemensh@chromium.org, jgruber@chromium.org BUG=v8:5530 ========== to ========== [debugger,api] deprecate everything in v8-debug.h R=clemensh@chromium.org, jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2727393003 Cr-Commit-Position: refs/heads/master@{#43714} Committed: https://chromium.googlesource.com/v8/v8/+/faf5f52627cdb398cac2f756e79dba042c4... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/v8/v8/+/faf5f52627cdb398cac2f756e79dba042c4... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
