Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issue 2727393002: DevTools: fix FrameResource.lastModified to be optional when not present (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix FrameResource.lastModified to be optional when not present This patch fixes FrameResource.lastModified to be optional when not returned by server. BUG=696358 Review-Url: https://codereview.chromium.org/2727393002 Cr-Commit-Position: refs/heads/master@{#454516} Committed: https://chromium.googlesource.com/chromium/src/+/22e8735948a7c60d393250be79c9959d218faafe

Patch Set 1 #

Patch Set 2 : use std::isnan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
lushnikov
please, take a look
3 years, 9 months ago (2017-03-03 02:17:34 UTC) #2
pfeldman
lgtm
3 years, 9 months ago (2017-03-03 02:20:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727393002/1
3 years, 9 months ago (2017-03-03 02:33:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/293095) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-03 03:03:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727393002/1
3 years, 9 months ago (2017-03-03 03:45:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727393002/20001
3 years, 9 months ago (2017-03-03 03:48:40 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 05:27:08 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/22e8735948a7c60d393250be79c9...

Powered by Google App Engine
This is Rietveld 408576698