Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2727383002: DevTools: sort sourceMap mappings since they might not be ordered. (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: sort sourceMap mappings since they might not be ordered. This patch stable-sorts mappings in the source map, since the spec doesn't actually require them to be sorted. BUG=687772 R=dgozman, pfeldman Review-Url: https://codereview.chromium.org/2727383002 Cr-Commit-Position: refs/heads/master@{#454494} Committed: https://chromium.googlesource.com/chromium/src/+/a9edbc7f8483a52d2ec12e351c4ba1ee07414ab5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/text-source-map.html View 2 chunks +24 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/text-source-map-expected.txt View 2 chunks +15 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
lushnikov
please, take a look
3 years, 9 months ago (2017-03-03 01:49:19 UTC) #1
pfeldman
lgtm
3 years, 9 months ago (2017-03-03 02:21:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727383002/1
3 years, 9 months ago (2017-03-03 02:32:47 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 03:16:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a9edbc7f8483a52d2ec12e351c4b...

Powered by Google App Engine
This is Rietveld 408576698