Issue 2727373003: Late creation of CodegenEnqueuerListener and CodegenWorldBuilder

Issue 2727373003: Late creation of CodegenEnqueuerListener and CodegenWorldBuilder (Closed)

Created:
3 years, 9 months ago by Johnni Winther

Modified:
3 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Late creation of CodegenEnqueuerListener and CodegenWorldBuilder - now with no reference to JavaScriptBackend! R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/452c380db1a840031ce3f22d73e0ec56f82a75cf

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -66 lines)			Patch
M	pkg/compiler/lib/src/compiler.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/enqueue.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View	5 chunks	+23 lines, -17 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen_listener.dart	View	3 chunks	+7 lines, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/enqueuer.dart	View	8 chunks	+12 lines, -17 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/mirrors_analysis.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/universe/codegen_world_builder.dart	View	3 chunks	+3 lines, -18 lines	0 comments	Download
M	tests/compiler/dart2js/type_representation_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (3 generated)

Siggi Cherem (dart-lang)

lgtm Consider updating the CL description to also say that the codegen-world-builder now is also ...

3 years, 9 months ago (2017-03-14 03:22:33 UTC) #3

Johnni Winther

3 years, 9 months ago (2017-03-15 10:08:58 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
452c380db1a840031ce3f22d73e0ec56f82a75cf (presubmit successful).