Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen_listener.dart

Issue 2727373003: Late creation of CodegenEnqueuerListener and CodegenWorldBuilder (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_backend/enqueuer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/codegen_listener.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen_listener.dart b/pkg/compiler/lib/src/js_backend/codegen_listener.dart
index cb3b2155d899d3beb3081f656acfe792f97c4b1d..c3137397c17c2b29f27dd08528a982a9c45c0010 100644
--- a/pkg/compiler/lib/src/js_backend/codegen_listener.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen_listener.dart
@@ -26,14 +26,16 @@ import 'mirrors_data.dart';
import 'type_variable_handler.dart';
class CodegenEnqueuerListener extends EnqueuerListener {
- // TODO(johnniwinther): Avoid the need for accessing through [_backend].
- final JavaScriptBackend _backend;
+ // TODO(johnniwinther): Remove this.
+ final DumpInfoTask _dumpInfoTask;
final ElementEnvironment _elementEnvironment;
final CommonElements _commonElements;
final BackendHelpers _helpers;
final BackendImpacts _impacts;
+ final BackendUsage _backendUsage;
+ final RuntimeTypesNeed _rtiNeed;
final MirrorsData _mirrorsData;
final CustomElementsCodegenAnalysis _customElementsAnalysis;
@@ -46,11 +48,13 @@ class CodegenEnqueuerListener extends EnqueuerListener {
bool _noSuchMethodEnabledForCodegen = false;
CodegenEnqueuerListener(
- this._backend,
+ this._dumpInfoTask,
this._elementEnvironment,
this._commonElements,
this._helpers,
this._impacts,
+ this._backendUsage,
+ this._rtiNeed,
this._mirrorsData,
this._customElementsAnalysis,
this._typeVariableHandler,
@@ -58,11 +62,6 @@ class CodegenEnqueuerListener extends EnqueuerListener {
this._mirrorsAnalysis,
this._nativeEnqueuer);
- // TODO(johnniwinther): Change these to final fields.
- DumpInfoTask get _dumpInfoTask => _backend.compiler.dumpInfoTask;
- RuntimeTypesNeed get _rtiNeed => _backend.rtiNeed;
- BackendUsage get _backendUsage => _backend.backendUsage;
-
@override
WorldImpact registerClosurizedMember(MemberElement element) {
WorldImpactBuilderImpl impactBuilder = new WorldImpactBuilderImpl();
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_backend/enqueuer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698