Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2727373002: [DevTools] prepare tets for V8 roll (Closed)

Created:
3 years, 9 months ago by kozy
Modified:
3 years, 9 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] prepare tets for V8 roll V8 roll will fix endLine for scripts with empty end line at the end (most scripts). BUG=chromium:698077, chromium:697334 TBR=lushnikov@chromium.org Review-Url: https://codereview.chromium.org/2727373002 Cr-Commit-Position: refs/heads/master@{#454487} Committed: https://chromium.googlesource.com/chromium/src/+/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Messages

Total messages: 12 (6 generated)
kozy
https://codereview.chromium.org/2727373002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger/debug-inlined-scripts.html File third_party/WebKit/LayoutTests/inspector/sources/debugger/debug-inlined-scripts.html (right): https://codereview.chromium.org/2727373002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger/debug-inlined-scripts.html#newcode44 third_party/WebKit/LayoutTests/inspector/sources/debugger/debug-inlined-scripts.html:44: InspectorTest.waitJavaScriptSourceFrameBreakpoints(sourceFrame) We need to wait correct location before reload ...
3 years, 9 months ago (2017-03-03 01:21:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727373002/1
3 years, 9 months ago (2017-03-03 01:21:50 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/164066) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-03 01:24:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727373002/40001
3 years, 9 months ago (2017-03-03 01:41:06 UTC) #8
lushnikov
lgtm
3 years, 9 months ago (2017-03-03 02:56:10 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 03:05:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/77169d413d6a7cf5d4d4d1ee552c...

Powered by Google App Engine
This is Rietveld 408576698