Compile Image Editor in gyp v2

Compile Image Editor in gyp v2

Renamed ImageEditor.Mode to ImageEditorMode and extracted the file for this.
Renamed ImageEditor.Toolbar to ImageEditorToolbar and extracted the file for this.
Removed dependency from ImageEditorMode to ImageEditor:
- registerAction_ and modeToolbar_.reset are called by ImageEditor instead of ImageEditor.Mode.
- arguments for ImageEditorMode.prototype.bind is changed not to take ImageEditor.
Formatted the edited code with `git cl format --js`.


BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2727353004
Cr-Commit-Position: refs/heads/master@{#455053}
Committed: https://chromium.googlesource.com/chromium/src/+/a5347c7133cb9b84a9c9801ca307343ed3ed4947

[oka, 2017-03-03 13:44:33]

Description was changed from

==========
Compile Image Editor.

ImageEditor.Mode -> ImageEditorMode
ImageEditor.Toolbar -> ImageEditorToolbar
Removed dependency from ImageEditorMode to ImageEditor.

BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
==========

to

==========
Compile Image Editor.

ImageEditor.Mode -> ImageEditorMode
ImageEditor.Toolbar -> ImageEditorToolbar
Removed dependency from ImageEditorMode to ImageEditor.

BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-03-03 13:45:03]

Description was changed from

==========
Compile Image Editor.

ImageEditor.Mode -> ImageEditorMode
ImageEditor.Toolbar -> ImageEditorToolbar
Removed dependency from ImageEditorMode to ImageEditor.

BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile Image Editor.

ImageEditor.Mode -> ImageEditorMode
ImageEditor.Toolbar -> ImageEditorToolbar
Removed dependency from ImageEditorMode to ImageEditor.
Formatted the edited code with 'git cl format --js'.

BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-03-03 13:45:15]

Description was changed from

==========
Compile Image Editor.

ImageEditor.Mode -> ImageEditorMode
ImageEditor.Toolbar -> ImageEditorToolbar
Removed dependency from ImageEditorMode to ImageEditor.
Formatted the edited code with 'git cl format --js'.

BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile Image Editor.

ImageEditor.Mode -> ImageEditorMode
ImageEditor.Toolbar -> ImageEditorToolbar
Removed dependency from ImageEditorMode to ImageEditor.
Formatted the edited code with `git cl format --js`.

BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-03-03 13:45:19]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 13:45:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-03-03 13:50:23]

.

[oka, 2017-03-03 13:52:02]

.

[oka, 2017-03-03 13:52:59]

.

[oka, 2017-03-03 14:02:33]

oka@chromium.org changed reviewers:
+ dbeam@chromium.org, fukino@chromium.org

[oka, 2017-03-03 14:02:33]

PTAL.
dbeam@ for ui/webui/resources/js/cr/ui/compiled_resources2.gyp
fukino@ for others.

[oka, 2017-03-03 14:02:52]

Description was changed from

==========
Compile Image Editor.

ImageEditor.Mode -> ImageEditorMode
ImageEditor.Toolbar -> ImageEditorToolbar
Removed dependency from ImageEditorMode to ImageEditor.
Formatted the edited code with `git cl format --js`.

BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile Image Editor in gyp v2

ImageEditor.Mode -> ImageEditorMode
ImageEditor.Toolbar -> ImageEditorToolbar
Removed dependency from ImageEditorMode to ImageEditor.
Formatted the edited code with `git cl format --js`.

BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-03-03 14:38:11]

.

[oka, 2017-03-03 14:38:23]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 14:38:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-03-03 14:43:07]

Compile more targets in Gallery.

[Dan Beam, 2017-03-06 00:10:15]

lgtm

[fukino, 2017-03-06 01:50:35]

looking good, but is it possible to tweak the similarity parameter to see the
diff from the code which is removed from image_editor.js and the code which is
added as new file?
(I guess the actual changes are in ImageEditorMode.bind() and reset()?)

[oka, 2017-03-06 01:57:31]

I tried it but failed to produce meaningfull diff.

2017年3月6日(月) 10:50 <fukino@chromium.org>:

> looking good, but is it possible to tweak the similarity parameter to see
> the
> diff from the code which is removed from image_editor.js and the code
> which is
> added as new file?
> (I guess the actual changes are in ImageEditorMode.bind() and reset()?)
>
> https://codereview.chromium.org/2727353004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[fukino, 2017-03-06 02:04:15]

On 2017/03/06 01:57:31, oka wrote:
> I tried it but failed to produce meaningfull diff.

OK. Instead, could you describe the changes which are not simple(rename or move)
in the bug description?

[oka, 2017-03-07 06:12:08]

Description was changed from

==========
Compile Image Editor in gyp v2

ImageEditor.Mode -> ImageEditorMode
ImageEditor.Toolbar -> ImageEditorToolbar
Removed dependency from ImageEditorMode to ImageEditor.
Formatted the edited code with `git cl format --js`.

BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile Image Editor in gyp v2

Renamed ImageEditor.Mode to ImageEditorMode and extracted the file for this.
Renamed ImageEditor.Toolbar to ImageEditorToolbar and extracted the file for
this.
Removed dependency from ImageEditorMode to ImageEditor.
Formatted the edited code with `git cl format --js`.

BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-03-07 06:13:37]

On 2017/03/06 02:04:15, fukino wrote:
> On 2017/03/06 01:57:31, oka wrote:
> > I tried it but failed to produce meaningfull diff.
> 
> OK. Instead, could you describe the changes which are not simple(rename or
move)
> in the bug description?

Done. Could you take a look?

[oka, 2017-03-07 06:30:20]

Description was changed from

==========
Compile Image Editor in gyp v2

Renamed ImageEditor.Mode to ImageEditorMode and extracted the file for this.
Renamed ImageEditor.Toolbar to ImageEditorToolbar and extracted the file for
this.
Removed dependency from ImageEditorMode to ImageEditor.
Formatted the edited code with `git cl format --js`.

BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile Image Editor in gyp v2

Renamed ImageEditor.Mode to ImageEditorMode and extracted the file for this.
Renamed ImageEditor.Toolbar to ImageEditorToolbar and extracted the file for
this.
Removed dependency from ImageEditorMode to ImageEditor; registerAction_ and
modeToolbar_.reset are called by ImageEditor instead of ImageEditor.Mode.

Formatted the edited code with `git cl format --js`.


BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-03-07 06:32:34]

Description was changed from

==========
Compile Image Editor in gyp v2

Renamed ImageEditor.Mode to ImageEditorMode and extracted the file for this.
Renamed ImageEditor.Toolbar to ImageEditorToolbar and extracted the file for
this.
Removed dependency from ImageEditorMode to ImageEditor; registerAction_ and
modeToolbar_.reset are called by ImageEditor instead of ImageEditor.Mode.

Formatted the edited code with `git cl format --js`.


BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile Image Editor in gyp v2

Renamed ImageEditor.Mode to ImageEditorMode and extracted the file for this.
Renamed ImageEditor.Toolbar to ImageEditorToolbar and extracted the file for
this.
Removed dependency from ImageEditorMode to ImageEditor:
- registerAction_ and modeToolbar_.reset are called by ImageEditor instead of
ImageEditor.Mode.
- arguments for ImageEditorMode.prototype.bind is changed not to take
ImageEditor.
Formatted the edited code with `git cl format --js`.


BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-03-07 06:33:34]

On 2017/03/07 06:13:37, oka wrote:
> On 2017/03/06 02:04:15, fukino wrote:
> > On 2017/03/06 01:57:31, oka wrote:
> > > I tried it but failed to produce meaningfull diff.
> > 
> > OK. Instead, could you describe the changes which are not simple(rename or
> move)
> > in the bug description?
> 
> Done. Could you take a look?

Update the description to mention non simple changes.

[oka, 2017-03-07 06:33:45]

PTAL.

[fukino, 2017-03-07 06:53:00]

LGTM. Thank you!

[oka, 2017-03-07 07:57:46]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2017-03-07 07:58:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 08:59:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 08:59:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2017-03-07 09:17:10]

.

[oka, 2017-03-07 09:17:53]

The CQ bit was checked by oka@chromium.org

[oka, 2017-03-07 09:17:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org,
fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2727353004/#ps150001
(title: ".")

[commit-bot: I haz the power, 2017-03-07 09:18:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 09:54:58]

CQ is committing da patch.

Bot data: {"patchset_id": 150001, "attempt_start_ts": 1488878273857070,
"parent_rev": "f763e19c781537524144758203e0d3f9f33bdfff", "commit_rev":
"a5347c7133cb9b84a9c9801ca307343ed3ed4947"}

[commit-bot: I haz the power, 2017-03-07 09:55:50]

Description was changed from

==========
Compile Image Editor in gyp v2

Renamed ImageEditor.Mode to ImageEditorMode and extracted the file for this.
Renamed ImageEditor.Toolbar to ImageEditorToolbar and extracted the file for
this.
Removed dependency from ImageEditorMode to ImageEditor:
- registerAction_ and modeToolbar_.reset are called by ImageEditor instead of
ImageEditor.Mode.
- arguments for ImageEditorMode.prototype.bind is changed not to take
ImageEditor.
Formatted the edited code with `git cl format --js`.


BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile Image Editor in gyp v2

Renamed ImageEditor.Mode to ImageEditorMode and extracted the file for this.
Renamed ImageEditor.Toolbar to ImageEditorToolbar and extracted the file for
this.
Removed dependency from ImageEditorMode to ImageEditor:
- registerAction_ and modeToolbar_.reset are called by ImageEditor instead of
ImageEditor.Mode.
- arguments for ImageEditorMode.prototype.bind is changed not to take
ImageEditor.
Formatted the edited code with `git cl format --js`.


BUG=636289
TEST=run_compiler.
- manually tested image edits can be done without errors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2727353004
Cr-Commit-Position: refs/heads/master@{#455053}
Committed:
https://chromium.googlesource.com/chromium/src/+/a5347c7133cb9b84a9c9801ca307...
==========

[commit-bot: I haz the power, 2017-03-07 09:55:51]

Committed patchset #9 (id:150001) as
https://chromium.googlesource.com/chromium/src/+/a5347c7133cb9b84a9c9801ca307...