Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2727343004: Add Feature params for UKM Service to control thresholds on sources and entries. (Closed)

Created:
3 years, 9 months ago by rkaplow
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Feature params for UKM Service to control thresholds on sources and entries. BUG=678682 Review-Url: https://codereview.chromium.org/2727343004 Cr-Commit-Position: refs/heads/master@{#454448} Committed: https://chromium.googlesource.com/chromium/src/+/91148407c7a785c2e49958dc99542626f7a77bbc

Patch Set 1 #

Patch Set 2 : ukm params2 #

Total comments: 1

Patch Set 3 : ukm params3 #

Patch Set 4 : wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -18 lines) Patch
M components/ukm/ukm_service.cc View 1 2 3 6 chunks +23 lines, -14 lines 0 comments Download
M components/ukm/ukm_service_unittest.cc View 1 1 chunk +34 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/2727343004/diff/20001/components/ukm/ukm_service.cc File components/ukm/ukm_service.cc (right): https://codereview.chromium.org/2727343004/diff/20001/components/ukm/ukm_service.cc#newcode80 components/ukm/ukm_service.cc:80: size_t GetMaxSources() { Nit: Can you add comments ...
3 years, 9 months ago (2017-03-02 23:13:42 UTC) #3
Alexei Svitkine (slow)
lgtm
3 years, 9 months ago (2017-03-02 23:22:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727343004/60001
3 years, 9 months ago (2017-03-02 23:25:14 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 00:10:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/91148407c7a785c2e49958dc9954...

Powered by Google App Engine
This is Rietveld 408576698