pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart - Issue 2727343002: Calculate text ranges for default args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart

Issue 2727343002: Calculate text ranges for default args. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/utilities.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart b/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart

index 448d848148159974d3ccee9e9887348d0f24894c..a00a87d40dd7824fc95256b1b6006a0357ec0d00 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart

@@ -81,8 +81,7 @@ CompletionSuggestion createSuggestion(Element element,

(ParameterElement param) => param.parameterKind == ParameterKind.NAMED);

suggestion.hasNamedParameters = namedParameters.isNotEmpty;

- suggestion.defaultArgumentListString =

- buildDefaultArgList(requiredParameters, namedParameters);

+ addDefaultArgDetails(suggestion, requiredParameters, namedParameters);

}

if (importForSource != null) {

String srcPath = path.dirname(importForSource.fullName);